Improve postcode.php #1

Merged
merged 6 commits into from Jun 22, 2012

Projects

None yet

2 participants

@dracos

Hi,

For any two-tier council, postcode.php is making two identical requests to mapit. It is also making its mapit requests invalidly, either by not escaping properly postcodes with a space, or by not using a postcode at all (if from a lat/lon request). It doesn't check the database results for parishes correctly, and doesn't exit when doing a redirect, leading to mapit calls being made which are then made again after the redirect takes place.

This pull request should fix all the above.

@pezholio pezholio merged commit 9f064a3 into pezholio:master Jun 22, 2012
@pezholio
Owner

Excellent, thanks Matthew. And thanks for being so understanding about me using Mapit. If I could find a free host that supported PostGIS, I'd probably have no need for Mapit! :)

@dracos

Did you get my email?

@pezholio
Owner

Yes. Sorry! Things went a bit mad on Friday. Will respond now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment