Browse files

lib/flex_proportions.c: fix corruption of denominator in flexible pro…


When racing with CPU hotplug, percpu_counter_sum() can return negative
values for the number of observed events.

This confuses fprop_new_period(), which uses unsigned type and as a
result number of events is set to big *positive* number.  From that
moment on, things go pear shaped and can result e.g.  in division by
zero as denominator is later truncated to 32-bits.

This bug causes a divide-by-zero oops in bdi_dirty_limit() in Borislav's
3.6.0-rc6 based kernel.

Fix the issue by using a signed type in fprop_new_period().  That makes
us bail out from the function without doing anything (mistakenly)
thinking there are no events to age.  That makes aging somewhat
inaccurate but getting accurate data would be rather hard.

Signed-off-by: Jan Kara <>
Reported-by: Borislav Petkov <>
Reported-by: Srivatsa S. Bhat <>
Cc: Wu Fengguang <>
Cc: Peter Zijlstra <>
Cc: <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
  • Loading branch information...
1 parent 0e75898 commit b5bd6a0e5fa8c0376d9746c566fe3daaa51ec825 @jankara jankara committed with torvalds Sep 25, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/flex_proportions.c
2 lib/flex_proportions.c
@@ -62,7 +62,7 @@ void fprop_global_destroy(struct fprop_global *p)
bool fprop_new_period(struct fprop_global *p, int periods)
- u64 events;
+ s64 events;
unsigned long flags;

0 comments on commit b5bd6a0

Please sign in to comment.