HTTPS clone URL
Subversion checkout URL
Please sign in to comment.
lib/flex_proportions.c: fix corruption of denominator in flexible pro…
…portions When racing with CPU hotplug, percpu_counter_sum() can return negative values for the number of observed events. This confuses fprop_new_period(), which uses unsigned type and as a result number of events is set to big *positive* number. From that moment on, things go pear shaped and can result e.g. in division by zero as denominator is later truncated to 32-bits. This bug causes a divide-by-zero oops in bdi_dirty_limit() in Borislav's 3.6.0-rc6 based kernel. Fix the issue by using a signed type in fprop_new_period(). That makes us bail out from the function without doing anything (mistakenly) thinking there are no events to age. That makes aging somewhat inaccurate but getting accurate data would be rather hard. Signed-off-by: Jan Kara <email@example.com> Reported-by: Borislav Petkov <firstname.lastname@example.org> Reported-by: Srivatsa S. Bhat <email@example.com> Cc: Wu Fengguang <firstname.lastname@example.org> Cc: Peter Zijlstra <email@example.com> Cc: <firstname.lastname@example.org> Signed-off-by: Andrew Morton <email@example.com> Signed-off-by: Linus Torvalds <firstname.lastname@example.org>
- Loading branch information...