Browse files

netdev: pasemi: fix return value check in pasemi_mac_phy_init()

In case of error, the function of_phy_connect() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

dpatch engine is used to auto generate this patch.

Signed-off-by: Wei Yongjun <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent a326e6d commit beb5ac20b3f90ffabac1eecd3c00205255df0728 Wei Yongjun committed with davem330 Sep 26, 2012
Showing with 2 additions and 2 deletions.
  1. +2 −2 drivers/net/ethernet/pasemi/pasemi_mac.c
@@ -1101,9 +1101,9 @@ static int pasemi_mac_phy_init(struct net_device *dev)
phydev = of_phy_connect(dev, phy_dn, &pasemi_adjust_link, 0,
- if (IS_ERR(phydev)) {
+ if (!phydev) {
printk(KERN_ERR "%s: Could not attach to phy\n", dev->name);
- return PTR_ERR(phydev);
+ return -ENODEV;
mac->phydev = phydev;

0 comments on commit beb5ac2

Please sign in to comment.