Skip to content
Browse files

netdev: octeon: fix return value check in octeon_mgmt_init_phy()

In case of error, the function of_phy_connect() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

dpatch engine is used to auto generate this patch.

Signed-off-by: Wei Yongjun <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent bc9259a commit df555b665367f9de6c04826acc482096f17c243d Wei Yongjun committed with davem330
Showing with 1 addition and 3 deletions.
  1. +1 −3 drivers/net/ethernet/octeon/octeon_mgmt.c
4 drivers/net/ethernet/octeon/octeon_mgmt.c
@@ -722,10 +722,8 @@ static int octeon_mgmt_init_phy(struct net_device *netdev)
octeon_mgmt_adjust_link, 0,
- if (IS_ERR(p->phydev)) {
- p->phydev = NULL;
+ if (!p->phydev)
return -1;
- }

0 comments on commit df555b6

Please sign in to comment.
Something went wrong with that request. Please try again.