Skip to content
Commits on Mar 5, 2006
  1. @chriswright

    Linux 2.6.15.6

    chriswright committed Mar 5, 2006
  2. @kernelslacker @chriswright

    [PATCH] mempolicy.c compile fix, make sure BITS_PER_BYTE is defined

    Gar..
    
    mm/mempolicy.c: In function 'get_nodes':
    mm/mempolicy.c:527: error: 'BITS_PER_BYTE' undeclared (first use in this function)
    mm/mempolicy.c:527: error: (Each undeclared identifier is reported only once
    mm/mempolicy.c:527: error: for each function it appears in.)
    
    About to retry a build with the below patch which should do the trick.
    (How did this *ever* build?)
    
    Signed-off-by: Dave Jones <davej@redhat.com>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    kernelslacker committed with chriswright Mar 1, 2006
  3. @chriswright

    [PATCH] fs/nfs/direct.c compile fix

    Compile fix:
    
    fs/nfs/direct.c: In function 'nfs_get_user_pages':
    fs/nfs/direct.c:110: warning: implicit declaration of function 'nfs_free_user_pages'
    fs/nfs/direct.c: At top level:
    fs/nfs/direct.c:127: warning: conflicting types for 'nfs_free_user_pages'
    fs/nfs/direct.c:127: error: static declaration of 'nfs_free_user_pages' follows non-static declaration
    fs/nfs/direct.c:110: error: previous implicit declaration of 'nfs_free_user_pages' was here
    
    This should now be the same as fix that's going upstream.
    
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
    chriswright committed Mar 1, 2006
  4. @chriswright

    [PATCH] die_if_kernel() can return (CVE-2006-0742)

    arch/ia64/kernel/unaligned.c erroneously marked die_if_kernel()
    with a "noreturn" attribute ... which is silly (it returns whenever
    the argument regs say that the fault happened in user mode, as one
    might expect given the "if_kernel" part of its name!).  Thanks to
    Alan and Gareth for pointing this out.
    
    Signed-off-by: Tony Luck <tony.luck@intel.com>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Tony Luck committed with chriswright Feb 27, 2006
  5. @chriswright

    [PATCH] Don't reset rskq_defer_accept in reqsk_queue_alloc

    In 295f732 I moved defer_accept from
    tcp_sock to request_queue and mistakingly reset it at reqsl_queue_alloc, causing
    calls to setsockopt(TCP_DEFER_ACCEPT ) to be lost after bind, the fix is to
    remove the zeroing of rskq_defer_accept from reqsl_queue_alloc.
    
    Thanks to Alexandra N. Kossovsky <Alexandra.Kossovsky@oktetlabs.ru> for
    reporting and testing the suggested fix.
    
    Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Arnaldo Carvalho de Melo committed with chriswright Feb 27, 2006
Commits on Mar 1, 2006
  1. @chriswright

    Linux 2.6.15.5

    chriswright committed Mar 1, 2006
  2. @chriswright

    [PATCH] IB/mthca: max_inline_data handling tweaks

    Fix a case where copying max_inline_data from a successful create_qp
    capabilities output to create_qp input could cause EINVAL error:
    
    mthca_set_qp_size must check max_inline_data directly against
    max_desc_sz; checking qp->sq.max_gs is wrong since max_inline_data
    depends on the qp type and does not involve max_sg.
    
    Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il>
    Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
    Signed-off-by: Roland Dreier <rolandd@cisco.com>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Jack Morgenstein committed with chriswright Feb 27, 2006
  3. @chriswright

    [PATCH] Normal user can panic NFS client with direct I/O (CVE-2006-0555)

    This is CVE-2006-0555 and SGI bug 946529.  A normal user can panic an
    NFS client and cause a local DoS with 'judicious'(?) use of O_DIRECT.
    
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Trond Myklebust committed with chriswright Feb 15, 2006
  4. @chriswright

    [PATCH] XFS ftruncate() bug could expose stale data (CVE-2006-0554)

    This is CVE-2006-0554 and SGI bug 942658.  With certain types of
    ftruncate() activity on 2.6 kernels, XFS can end up exposing stale
    data off disk to a user, putting extents where holes should be.
    
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Mike O'Connor committed with chriswright Feb 15, 2006
  5. @chriswright

    [PATCH] sbp2: fix another deadlock after disconnection

    sbp2: fix another deadlock after disconnection
    
    If there were commands enqueued but not completed before an SBP-2 unit
    was unplugged (or an attempt to reconnect failed), knodemgrd or any
    process which tried to remove the device would sleep uninterruptibly
    in blk_execute_rq().  Therefore make sure that all commands are
    completed when sbp2 retreats.
    
    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Stefan Richter committed with chriswright Feb 27, 2006
  6. @chriswright

    [PATCH] sd: fix memory corruption with broken mode page headers

    sd: fix memory corruption with broken mode page headers
    
    There's a problem in sd where we blindly believe the length of the
    headers and block descriptors.  Some devices return insane values for
    these and cause our length to end up greater than the actual buffer
    size, so check to make sure.
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    
    Also removed the buffer size magic number (512) and added DPOFUA of
    zero to the defaults
    
    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    
    rediff for 2.6.15.x without DPOFUA bit, taken from commit
    4897080
    
    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Stefan Richter committed with chriswright Feb 27, 2006
  7. @chriswright

    [PATCH] Fix a severe bug

    netlink overrun was broken while improvement of netlink.
    Destination socket is used in the place where it was meant to be source socket,
    so that now overrun is never sent to user netlink sockets, when it should be,
    and it even can be set on kernel socket, which results in complete deadlock
    of rtnetlink.
    
    Suggested fix is to restore status quo passing source socket as additional
    argument to netlink_attachskb().
    
    A little explanation: overrun is set on a socket, when it failed
    to receive some message and sender of this messages does not or even
    have no way to handle this error. This happens in two cases:
    1. when kernel sends something. Kernel never retransmits and cannot
       wait for buffer space.
    2. when user sends a broadcast and the message was not delivered
       to some recipients.
    
    Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Alexey Kuznetsov committed with chriswright Feb 27, 2006
  8. @chriswright

    [PATCH] x86_64: Check for bad elf entry address (CVE-2006-0741)

    Fixes a local DOS on Intel systems that lead to an endless
    recursive fault.  AMD machines don't seem to be affected.
    
    Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
    Signed-off-by: Andi Kleen <ak@suse.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Suresh Siddha committed with chriswright Feb 26, 2006
  9. @chriswright

    [PATCH] skge: fix SMP race

    If skge is attached to a bad cable, that goes up/down.
    It exposes an SMP race with the management of IRQ mask
    
    Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Stephen Hemminger committed with chriswright Feb 22, 2006
  10. @chriswright

    [PATCH] skge: genesis phy initialization fix

    The SysKonnect Genesis based board would fail on initialization
    with phy_read errors caused by not waiting for last phy write.
    
    Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Stephen Hemminger committed with chriswright Feb 22, 2006
  11. @chriswright

    [PATCH] skge: fix NAPI/irq race

    Fix a race in the receive NAPI, irq handling. The interrupt clear and the
    start need to be separated.  Otherwise there is a window between the last
    frame received and the NAPI done level handling.
    
    Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Stephen Hemminger committed with chriswright Feb 22, 2006
  12. @chriswright

    [PATCH] skge: speed setting

    This is a clone of John Linville's fixed for speed setting on sky2 driver.
    The skge driver has the same code (and bug). It would not allow manually forcing
    100 and 10 mbit.
    
    Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Stephen Hemminger committed with chriswright Feb 22, 2006
  13. @oniongarlic @chriswright

    [PATCH] gbefb: IP32 gbefb depth change fix

    The gbefb driver does not update the framebuffer layers visual setting when
    depth is changed with fbset, resulting in strange colors (very dark blue in
    16-bit, almost black in 24-bit).
    
    Signed-off-by: Kaj-Michael Lang <milang@tal.org>
    Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
    Signed-off-by: Antonino Daplas <adaplas@pol.net>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    oniongarlic committed with chriswright Feb 24, 2006
  14. @chriswright

    [PATCH] ramfs: update dir mtime and ctime

    Phil Marek <philipp.marek@bmlv.gv.at> points out that ramfs forgets to update
    a directory's mtime and ctime when it is modified.
    
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Andrew Morton committed with chriswright Feb 24, 2006
  15. @chriswright

    [PATCH] dm: free minor after unlink gendisk

    Minor number should be freed after del_gendisk().  Otherwise, there could
    be a window where 2 registered gendisk has same minor number.
    
    Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
    Acked-by: Alasdair G Kergon <agk@redhat.com>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    [chrisw: backport to 2.6.15]
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Jun'ichi Nomura committed with chriswright Feb 24, 2006
  16. @chriswright

    [PATCH] dm: missing bdput/thaw_bdev at removal

    Need to unfreeze and release bdev otherwise the bdev inode with
    inconsistent state is reused later and cause problem.
    
    Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
    Acked-by: Alasdair G Kergon <agk@redhat.com>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    [chrisw: backport to 2.6.15]
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Jun'ichi Nomura committed with chriswright Feb 24, 2006
  17. @tbm @chriswright

    [PATCH] gbefb: Set default of FB_GBE_MEM to 4 MB

    Allocating more than 4 MB memory for the GBE (SGI O2) framebuffer completely
    breakfs gbefb support at the moment.  According to comments on #mipslinux,
    more than 4 MB has never worked correctly in Linux.  Therefore, the default
    should be 4 MB.
    
    Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
    Signed-off-by: Antonino Daplas <adaplas@pol.net>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    tbm committed with chriswright Feb 24, 2006
  18. @chriswright

    [PATCH] cfi: init wait queue in chip struct

    Fix a kernel oops for Intel P30 flashes, where the wait queue head was not
    initialized for the flchip struct, which in turn caused a crash at the
    first read operation.
    
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Simon Vogl committed with chriswright Feb 24, 2006
  19. @tiwai @chriswright

    [PATCH] alsa: fix bogus snd_device_free() in opl3-oss.c

    Remove snd_device_free() for an opl3-oss instance which should have been
    released.
    
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Cc: Jaroslav Kysela <perex@suse.cz>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    tiwai committed with chriswright Feb 24, 2006
  20. @jkreileder @chriswright

    [PATCH] Fix snd-usb-audio in 32-bit compat environment

    I'm getting oopses with snd-usb-audio in 32-bit compat environments:
    control_compat.c:get_ctl_type() doesn't initialize 'info', so
    'itemlist[uinfo->value.enumerated.item]' in
    usbmixer.c:mixer_ctl_selector_info() might access random memory (The 'if
    ((int)uinfo->value.enumerated.item >= cval->max)' doesn't fix all problems
    because of the unsigned -> signed conversion.)
    
    Signed-off-by: Juergen Kreileder <jk@blackdown.de>
    Cc: Jaroslav Kysela <perex@suse.cz>
    Acked-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jkreileder committed with chriswright Feb 20, 2006
  21. @chriswright

    [PATCH] hwmon it87: Probe i2c 0x2d only

    Only scan I2C address 0x2d. This is the default address and no IT87xxF
    chip was ever seen on I2C at a different address. These chips are
    better accessed through their ISA interface anyway.
    
    This fixes bug #5889, although it doesn't address the whole class
    of problems. We'd need the ability to blacklist arbitrary I2C addresses
    on systems known to contain I2C devices which behave badly when probed.
    
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jean Delvare committed with chriswright Feb 19, 2006
  22. @chriswright

    [PATCH] it87: Fix oops on removal

    Fix an oops on it87 module removal when no supported hardware was
    found.
    
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Jean Delvare committed with chriswright Feb 19, 2006
  23. @chriswright

    [PATCH] sys_mbind sanity checking

    Make sure maxnodes is safe size before calculating nlongs in
    get_nodes().
    
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    [chrisw: fix units, pointed out by Andi]
    Cc: Andi Kleen <ak@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    chriswright committed Feb 17, 2006
  24. @chriswright

    [PATCH] fix deadlock in ext2

    Fix a deadlock possible in the ext2 file system implementation.  This
    deadlock occurs when a file is removed from an ext2 file system which was
    mounted with the "sync" mount option.
    
    The problem is that ext2_xattr_delete_inode() was invoking the routine,
    sync_dirty_buffer(), using a buffer head which was previously locked via
    lock_buffer().  The first thing that sync_dirty_buffer() does is to lock
    the buffer head that it was passed.  It does this via lock_buffer().  Oops.
    
    The solution is to unlock the buffer head in ext2_xattr_delete_inode()
    before invoking sync_dirty_buffer().  This makes the code in
    ext2_xattr_delete_inode() obey the same locking rules as all other callers
    of sync_dirty_buffer() in the ext2 file system implementation.
    
    Signed-off-by: Peter Staubach <staubach@redhat.com>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Peter Staubach committed with chriswright Feb 17, 2006
  25. @chriswright

    [PATCH] fix zap_thread's ptrace related problems

    1. The tracee can go from ptrace_stop() to do_signal_stop()
       after __ptrace_unlink(p).
    
    2. It is unsafe to __ptrace_unlink(p) while p->parent may wait
       for tasklist_lock in ptrace_detach().
    
    Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
    Cc: Roland McGrath <roland@redhat.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Oleg Nesterov committed with chriswright Feb 15, 2006
  26. @chriswright

    [PATCH] Fix deadlock in br_stp_disable_bridge

    Looks like somebody forgot to use the _bh spin_lock variant. We ran into a
    deadlock where br->hello_timer expired while br_stp_disable_br() walked
    br->port_list.
    
    Signed-off-by: Adrian Drzewiecki <z@drze.net>
    Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Adrian Drzewiecki committed with chriswright Feb 15, 2006
  27. @kernelslacker @chriswright

    [PATCH] Fix s390 build failure.

    arch/s390/kernel/compat_signal.c:199: error: conflicting types for 'do_sigaction'
    include/linux/sched.h:1115: error: previous declaration of 'do_sigaction' was here
    
    Signed-off-by: Dave Jones <davej@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    kernelslacker committed with chriswright Feb 10, 2006
  28. @chriswright

    [PATCH] sys32_signal() forgets to initialize ->sa_mask

    Pointed out by Oleg Nesterov <oleg@tv-sign.ru>, who in turn
    got the hint from Linus.
    
    Signed-off-by: Tony Luck <tony.luck@intel.com>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Tony Luck committed with chriswright Feb 9, 2006
  29. @chriswright

    [PATCH] do_sigaction: cleanup ->sa_mask manipulation

    Clear unblockable signals beforehand.
    
    Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Oleg Nesterov committed with chriswright Feb 9, 2006
  30. @chriswright

    [PATCH] sys_signal: initialize ->sa_mask

    Pointed out by Linus Torvalds.
    
    sys_signal() forgets to initialize ->sa_mask.
    
    ( I suspect arch/ia64/ia32/ia32_signal.c:sys32_signal()
      also needs this fix )
    
    Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Oleg Nesterov committed with chriswright Feb 9, 2006
Something went wrong with that request. Please try again.