Permalink
Commits on Nov 16, 2007
  1. Linux 2.6.23.5

    gregkh committed Nov 16, 2007
  2. zd1211rw, fix oops when ejecting install media

    patch e0579d5 in mainline.
    
    The disconnect function can dereference the net_device structure when it
    is never allocated. This is the case when ejecting the device installer.
    
    Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
    Acked-by: Daniel Drake <dsd@gentoo.org>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    RandomReaper committed with gregkh Oct 26, 2007
  3. rtl8187: Fix more frag bit checking, rts duration calc

    patch 98798f4 in mainline.
    
    The wrong pointer is passed to ieee80211_get_morefrag. Fix this.
    
    While we're at it, reorder things so they look better and the rts duration
    calculation is done with the right length.
    
    Thanks to Christoph Hellwig for finding the ieee80211_get_morefrag issue.
    
    Signed-off-by: Michael Wu <flamingice@sourmilk.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Michael Wu committed with gregkh Oct 26, 2007
  4. ipw2100: send WEXT scan events

    patch d20c678 in mainline
    
    ipw2100 wasn't sending WEXT scan events at all on scan completion.  And
    like ipw2200, the driver aggressively auto-scans, requiring
    non-user-requested scan events to be batched together and sent at
    specific intervals instead of many times per seconds.
    
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    dcbw committed with gregkh Oct 26, 2007
  5. zd1201: avoid null ptr access of skb->dev

    patch 3ba72b2 in mainline.
    
    skb->dev is not set until eth_type_trans is called...
    
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    linvjw committed with gregkh Oct 26, 2007
  6. sky2: fix power settings on Yukon XL

    patch ff35164 in mainline.
    
    Make sure PCI register for PHY power gets set correctly.
    
    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Stephen Hemminger committed with gregkh Nov 6, 2007
  7. sky2: ethtool register reserved area blackout

    patch 295b54c in mainline.
    
    Make sure and not dump reserved areas of device space.
    Touching some of these causes machine check exceptions on boards
    like D-Link DGE-550SX.
    
    Coding note, used a complex switch statement rather than bitmap
    because it is easier to relate the block values to the documentation
    rather than looking at a encoded bitmask.
    
    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Stephen Hemminger committed with gregkh Nov 6, 2007
  8. sky2: status ring race fix

    patch ab5adec in mainline.
    
    The D-Link PCI-X board (and maybe others) can lie about status
    ring entries. It seems it will update the register for last status
    index before completing the DMA for the ring entry. To avoid reading
    stale data, zap the old entry and check.
    
    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Stephen Hemminger committed with gregkh Nov 6, 2007
  9. skge: XM PHY handling fixes

    patch 501fb72 in mainline.
    
    Change how PHY is managed on SysKonnect fibre based boards.
    Poll for PHY coming up 1 per second, but use interrupt to detect loss.
    
    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Stephen Hemminger committed with gregkh Nov 6, 2007
  10. Fix L2TP oopses.

    changeset 9178100 in mainline.
    
    [PPP]: L2TP: Fix oops in transmit and receive paths
    
    Changes made on 18-sep to fix skb handling in the pppol2tp driver
    broke the transmit and receive paths. Users are only running into this
    now because distros are now using 2.6.23 and I must have messed up
    when I tested the change.
    
    For receive, we now do our own calculation of how much to pull from
    the skb (variable length L2TP header) rather than using
    skb_transport_offset(). Also, if the skb isn't a data packet, it must
    be passed back to UDP with skb->data pointing to the UDP header.
    
    For transmit, make sure skb->sk is set up because ip_queue_xmit()
    needs it.
    
    Signed-off-by: James Chapman <jchapman@katalix.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    James Chapman committed with gregkh Nov 13, 2007
  11. TG3: Fix performance regression on 5705.

    patch 114342f in mainline.
    
    A performance regression was introduced by the following commit:
    
        commit ee6a99b
        Author: Michael Chan <mchan@broadcom.com>
        Date:   Wed Jul 18 21:49:10 2007 -0700
    
        [TG3]: Fix msi issue with kexec/kdump.
    
    In making that change, the PCI latency timer and cache line size
    registers were not restored after chip reset.  On the 5705, the
    latency timer gets reset to 0 during chip reset and this causes
    very poor performance.
    
    Update version to 3.81.1
    
    Signed-off-by: Michael Chan <mchan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Michael Chan committed with gregkh Oct 15, 2007
  12. forcedeth: add MCP77 device IDs

    patch 96fd4cd in mainline.
    
    Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Ayaz Abdulla committed with gregkh Oct 25, 2007
  13. forcedeth msi bugfix

    patch a747590 in mainline.
    
    pci_enable_msi() replaces the INTx irq number in pci_dev->irq with the
    new MSI irq number.
    The forcedeth driver did not update the copy in netdevice->irq and
    parts of the driver used the stale copy.
    See bugzilla.kernel.org, bug 9047.
    
    The patch
    - updates netdevice->irq
    - replaces all accesses to netdevice->irq with pci_dev->irq.
    
    The patch is against 2.6.23.1. IMHO suitable for both 2.6.23 and 2.6.24
    
    Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    manfred-colorfu committed with gregkh Oct 17, 2007
  14. ehea: 64K page kernel support fix

    based on 2c69448 in mainline.
    
    The current eHEA module compiled for 64K page kernels can not
    be loaded with insmod due to bad hypervisor call parameters.
    The patch is a subset of the follwing patch which has been applied
    for 2.6.24 upstream:
    
    http://www.spinics.net/lists/netdev/msg42814.html
    
    Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
    Cc: Jeff Garzik <jeff@garzik.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jan-Bernd Themann committed with gregkh Oct 16, 2007
  15. libertas: fix endianness breakage

    patch 5707708 in mainline.
    
    	wep->keytype[] is u8
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Al Viro committed with gregkh Oct 10, 2007
  16. libertas: more endianness breakage

    based on patch 8362cd4 in mainline.
    
    	domain->header.len is le16 and has just been assigned
    cpu_to_le16(arithmetical expression).  And all fields of adapter->logmsg
    are __le32; not a single 16-bit among them...
    	That's incremental to the previous one
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Al Viro committed with gregkh Oct 10, 2007
  17. Linux 2.6.23.4

    gregkh committed Nov 16, 2007
  18. mac80211: make ieee802_11_parse_elems return void

    patch 67a4cce in mainline.
    
    Some APs send management frames with junk padding after the last IE.
    We already account for a similar problem with some Apple Airport
    devices, but at least one device is known to send more than a single
    extra byte.  The device in question is the Draytek Vigor2900:
    
    	http://www.draytek.com.au/products/Vigor2900.php
    
    The junk in question looks like an IE that runs off the end of the
    frame.  This cause us to return ParseFailed.  Since the frame in
    question is an association response, this causes us to fail to associate
    with this AP.
    
    The return code from ieee802_11_parse_elems is superfluous.
    All callers still check for the presence of the specific IEs that
    interest them anyway.  So, remove the return code so the parse never
    "fails".
    
    Acked-by: Michael Wu <flamingice@sourmilk.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    linvjw committed with gregkh Oct 26, 2007
  19. mac80211: only honor IW_SCAN_THIS_ESSID in STA, IBSS, and AP modes

    patch d114f39 in mainline.
    
    The previous IW_SCAN_THIS_ESSID patch left a hole allowing scan
    requests on interfaces in inappropriate modes.
    
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    linvjw committed with gregkh Oct 26, 2007
  20. mac80211: honor IW_SCAN_THIS_ESSID in siwscan ioctl

    patch 107acb2 in mainline.
    
    This patch fixes the problem of associating with wpa_secured hidden
    AP.  Please try out.
    
    The original author of this patch is Bill Moss <bmoss@clemson.edu>
    
    Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    bmoss706 committed with gregkh Oct 26, 2007
  21. mac80211: store SSID in sta_bss_list

    patch cffdd30 in mainline.
    
    Some AP equipment "in the wild" services multiple SSIDs using the
    same BSSID.  This patch changes the key of sta_bss_list to include
    the SSID as well as the BSSID and the channel so as to prevent one
    SSID from eclipsing another SSID with the same BSSID.
    
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    linvjw committed with gregkh Oct 26, 2007
  22. mac80211: store channel info in sta_bss_list

    patch 65c107a in mainline.
    
    Some AP equipment "in the wild" uses the same BSSID on multiple channels
    (particularly "a" vs. "b/g").  This patch changes the key of sta_bss_list
    to include both the BSSID and the channel so as to prevent a BSSID on
    one channel from eclipsing the same BSSID on another channel.
    
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    linvjw committed with gregkh Oct 26, 2007
  23. mac80211: reorder association debug output

    patch 1dd84aa in mainline.
    
    There's no reason to warn about an invalid AID field when the
    association was denied.
    
    Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
    Acked-by: Michael Wu <flamingice@sourmilk.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jmberg committed with gregkh Oct 26, 2007
  24. ieee80211: fix TKIP QoS bug

    patch e797aa1 in mainline.
    
    The commit 65b6a27 titled "ieee80211: Fix header->qos_ctl endian issue"
    *introduced* an endianness bug. Partially revert it.
    
    Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jmberg committed with gregkh Oct 26, 2007
  25. NETFILTER: nf_conntrack_tcp: fix connection reopening

    Upstream commits: 1731139 + bc34b84 merged together.  Merge done by
    Patrick McHardy <kaber@trash.net>
    
    [NETFILTER]: nf_conntrack_tcp: fix connection reopening
    
    With your description I could reproduce the bug and actually you were
    completely right: the code above is incorrect. Somehow I was able to
    misread RFC1122 and mixed the roles :-(:
    
       When a connection is >>closed actively<<, it MUST linger in
       TIME-WAIT state for a time 2xMSL (Maximum Segment Lifetime).
       However, it MAY >>accept<< a new SYN from the remote TCP to
       reopen the connection directly from TIME-WAIT state, if it:
       [...]
    
    The fix is as follows: if the receiver initiated an active close, then the
    sender may reopen the connection - otherwise try to figure out if we hold
    a dead connection.
    
    Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
    Tested-by: Krzysztof Piotr Oledzki <ole@ans.pl>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jozsef Kadlecsik committed with gregkh Nov 5, 2007
  26. Fix netlink timeouts.

    [NETLINK]: Fix unicast timeouts
    
    [ Upstream commit: c3d8d1e ]
    
    Commit ed6dcf4a in the history.git tree broke netlink_unicast timeouts
    by moving the schedule_timeout() call to a new function that doesn't
    propagate the remaining timeout back to the caller. This means on each
    retry we start with the full timeout again.
    
    ipc/mqueue.c seems to actually want to wait indefinitely so this
    behaviour is retained.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    kaber committed with gregkh Nov 13, 2007
  27. Fix crypto_alloc_comp() error checking.

    [IPSEC]: Fix crypto_alloc_comp error checking
    
    [ Upstream commit: 4999f36 ]
    
    The function crypto_alloc_comp returns an errno instead of NULL
    to indicate error.  So it needs to be tested with IS_ERR.
    
    This is based on a patch by Vicenç Beltran Querol.
    
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    herbertx committed with gregkh Nov 13, 2007
  28. Fix SET_VLAN_INGRESS_PRIORITY_CMD error return.

    patch fffe470 in mainline.
    
    [VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl
    
    Based on report and patch by Doug Kehn <rdkehn@yahoo.com>:
    
    vconfig returns the following error when attempting to execute the
    set_ingress_map command:
    
    vconfig: socket or ioctl error for set_ingress_map: Operation not permitted
    
    In vlan.c, vlan_ioctl_handler for SET_VLAN_INGRESS_PRIORITY_CMD
    sets err = -EPERM and calls vlan_dev_set_ingress_priority.
    vlan_dev_set_ingress_priority is a void function so err remains
    at -EPERM and results in the vconfig error (even though the ingress
    map was set).
    
    Fix by setting err = 0 after the vlan_dev_set_ingress_priority call.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    kaber committed with gregkh Nov 13, 2007
  29. Fix VLAN address syncing.

    patch d932e04 in mainline.
    
    [PATCH] [VLAN]: Don't synchronize addresses while the vlan device is down
    
    While the VLAN device is down, the unicast addresses are not configured
    on the underlying device, so we shouldn't attempt to sync them.
    
    Noticed by Dmitry Butskoy <buc@odusz.so-cdu.ru>
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    kaber committed with gregkh Nov 13, 2007
  30. Fix endianness bug in U32 classifier.

    changeset 543821c in mainline.
    
    [PKT_SCHED] CLS_U32: Fix endianness problem with u32 classifier hash masks.
    
    While trying to implement u32 hashes in my shaping machine I ran into
    a possible bug in the u32 hash/bucket computing algorithm
    (net/sched/cls_u32.c).
    
    The problem occurs only with hash masks that extend over the octet
    boundary, on little endian machines (where htonl() actually does
    something).
    
    Let's say that I would like to use 0x3fc0 as the hash mask. This means
    8 contiguous "1" bits starting at b6. With such a mask, the expected
    (and logical) behavior is to hash any address in, for instance,
    192.168.0.0/26 in bucket 0, then any address in 192.168.0.64/26 in
    bucket 1, then 192.168.0.128/26 in bucket 2 and so on.
    
    This is exactly what would happen on a big endian machine, but on
    little endian machines, what would actually happen with current
    implementation is 0x3fc0 being reversed (into 0xc03f0000) by htonl()
    in the userspace tool and then applied to 192.168.x.x in the u32
    classifier. When shifting right by 16 bits (rank of first "1" bit in
    the reversed mask) and applying the divisor mask (0xff for divisor
    256), what would actually remain is 0x3f applied on the "168" octet of
    the address.
    
    One could say is this can be easily worked around by taking endianness
    into account in userspace and supplying an appropriate mask (0xfc03)
    that would be turned into contiguous "1" bits when reversed
    (0x03fc0000). But the actual problem is the network address (inside
    the packet) not being converted to host order, but used as a
    host-order value when computing the bucket.
    
    Let's say the network address is written as n31 n30 ... n0, with n0
    being the least significant bit. When used directly (without any
    conversion) on a little endian machine, it becomes n7 ... n0 n8 ..n15
    etc in the machine's registers. Thus bits n7 and n8 would no longer be
    adjacent and 192.168.64.0/26 and 192.168.128.0/26 would no longer be
    consecutive.
    
    The fix is to apply ntohl() on the hmask before computing fshift,
    and in u32_hash_fold() convert the packet data to host order before
    shifting down by fshift.
    
    With helpful feedback from Jamal Hadi Salim and Jarek Poplawski.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Radu Rendec committed with gregkh Nov 13, 2007
  31. Fix TEQL oops.

    [PKT_SCHED]: Fix OOPS when removing devices from a teql queuing discipline
    
    [ Upstream commit: 4f9f831 ]
    
    tecl_reset() is called from deactivate and qdisc is set to noop already,
    but subsequent teql_xmit does not know about it and dereference private
    data as teql qdisc and thus oopses.
    not catch it first :)
    
    Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Evgeniy Polyakov committed with gregkh Nov 13, 2007
  32. Fix error returns in sys_socketpair()

    patch bf3c23d in mainline.
    
    [NET]: Fix error reporting in sys_socketpair().
    
    If either of the two sock_alloc_fd() calls fail, we
    forget to update 'err' and thus we'll erroneously
    return zero in these cases.
    
    Based upon a report and patch from Rich Paul, and
    commentary from Chuck Ebbert.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    davem330 committed with gregkh Nov 13, 2007
  33. softmac: fix wext MLME request reason code endianness

    patch 94e10bf in mainline.
    
    The MLME request reason code is host-endian and our passing
    it to the low level functions is host-endian as well since
    they do the swapping. I noticed that the reason code 768 was
    sent (0x300) rather than 3 when wpa_supplicant terminates.
    This removes the superfluous cpu_to_le16() call.
    
    Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jmberg committed with gregkh Oct 25, 2007
  34. Fix kernel_accept() return handling.

    patch fa8705b in mainline.
    
    [NET]: sanitize kernel_accept() error path
    
    If kernel_accept() returns an error, it may pass back a pointer to
    freed memory (which the caller should ignore).  Make it pass back NULL
    instead for better safety.
    
    Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    abattersby committed with gregkh Oct 23, 2007
  35. TCP: Fix size calculation in sk_stream_alloc_pskb

    [TCP]: Fix size calculation in sk_stream_alloc_pskb
    
    [ Upstream commit: fb93134 ]
    
    We round up the header size in sk_stream_alloc_pskb so that
    TSO packets get zero tail room.  Unfortunately this rounding
    up is not coordinated with the select_size() function used by
    TCP to calculate the second parameter of sk_stream_alloc_pskb.
    
    As a result, we may allocate more than a page of data in the
    non-TSO case when exactly one page is desired.
    
    In fact, rounding up the head room is detrimental in the non-TSO
    case because it makes memory that would otherwise be available to
    the payload head room.  TSO doesn't need this either, all it wants
    is the guarantee that there is no tail room.
    
    So this patch fixes this by adjusting the skb_reserve call so that
    exactly the requested amount (which all callers have calculated in
    a precise way) is made available as tail room.
    
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    herbertx committed with gregkh Nov 14, 2007