Skip to content
Commits on Oct 18, 2008
  1. @gregkh


    gregkh committed
  2. @gregkh

    netdrvr: atl1e: Don't take the mdio_lock in atl1e_probe

    Matthew Wilcox committed with gregkh
    commit f382a0a upstream
    Lockdep warns about the mdio_lock taken with interrupts enabled then later
    taken from interrupt context.  Initially, I considered changing these
    to spin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init()
    and saw that it calls msleep().  Sleeping while holding a spinlock is
    not allowed either.
    In the probe path, we haven't registered the interrupt handler, so
    it can't poke at this card yet.  It's before we call register_netdev(),
    so I don't think any other threads can reach this card either.  If I'm
    right, we don't need a spinlock at all.
    Signed-off-by: Matthew Wilcox <>
    Cc: Jay Cliburn <>
    Signed-off-by: Jeff Garzik <>
    Signed-off-by: David S. Miller <>
    Signed-off-by: Greg Kroah-Hartman <>
  3. @rjwysocki @gregkh

    sky2: Fix WOL regression

    rjwysocki committed with gregkh
    commit 9d731d7 upstream
    Since dev->power.should_wakeup bit is used by the PCI core to
    decide whether the device should wake up the system from sleep
    states, set/unset this bit whenever WOL is enabled/disabled using
    Remove an open-coded reference to the standard PCI PM registers that
    is not used any more.
    Signed-off-by: Rafael J. Wysocki <>
    Cc: Tino Keitel <>
    Signed-off-by: David S. Miller <>
    Signed-off-by: Greg Kroah-Hartman <>
  4. @gregkh

    x86: improve UP kernel when CPU-hotplug and SMP is enabled

    Thomas Gleixner committed with gregkh
    commit 649c665 upstream
    num_possible_cpus() can be > 1 when disabled CPUs have been accounted.
    Disabled CPUs are not in the cpu_present_map, so we can use
    num_present_cpus() as a safe indicator to switch to UP alternatives.
    Reported-by: Chuck Ebbert <>
    Signed-off-by: Thomas Gleixner <>
    Signed-off-by: Ingo Molnar <>
    Signed-off-by: Greg Kroah-Hartman <>
  5. @gregkh

    x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC

    Andreas Herrmann committed with gregkh
    commit 33fb0e4 upstream
    On some HP nx6... laptops (e.g. nx6325) BIOS reports an IRQ0 override
    but the SB450 chipset is configured such that timer interrupts goe to
    INT0 of IOAPIC.
    Check IRQ0 routing and if it is routed to INT0 of IOAPIC skip the
    timer override.
    [ This more generic PCI ID based quirk should alleviate the need for
      dmi_ignore_irq0_timer_override DMI quirks. ]
    Signed-off-by: Andreas Herrmann <>
    Acked-by: "Maciej W. Rozycki" <>
    Tested-by: Dmitry Torokhov <>
    Signed-off-by: Ingo Molnar <>
    Signed-off-by: Greg Kroah-Hartman <>
  6. @gregkh

    x86, early_ioremap: fix fencepost error

    Alan Cox committed with gregkh
    commit c613ec1 upstream
    The x86 implementation of early_ioremap has an off by one error. If we get
    an object which ends on the first byte of a page we undermap by one page and
    this causes a crash on boot with the ASUS P5QL whose DMI table happens to fit
    this alignment.
    The size computation is currently
    	last_addr = phys_addr + size - 1;
    	npages = (PAGE_ALIGN(last_addr) - phys_addr)
    (Consider a request for 1 byte at alignment 0...)
    Closes #11693
    Debugging work by Ian Campbell/Felix Geyer
    Signed-off-by: Alan Cox <>
    Signed-off-by: Ingo Molnar <>
    Signed-off-by: Greg Kroah-Hartman <>
  7. @lwfinger @gregkh

    b43legacy: Fix failure in rate-adjustment mechanism

    lwfinger committed with gregkh
    commit c6a2afd upstream
    Date: Sat, 6 Sep 2008 16:51:22 -0500
    Subject: b43legacy: Fix failure in rate-adjustment mechanism
    A coding error present since b43legacy was incorporated into the
    kernel has prevented the driver from using the rate-setting mechanism
    of mac80211. The driver has been forced to remain at a 1 Mb/s rate.
    Signed-off-by: Larry Finger <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Greg Kroah-Hartman <>
  8. @dcbw @gregkh

    libertas: clear current command on card removal

    dcbw committed with gregkh
    commit 71b35f3 upstream
    If certain commands were in-flight when the card was pulled or the
    driver rmmod-ed, cleanup would block on the work queue stopping, but the
    work queue was in turn blocked on the current command being canceled,
    which didn't happen.  Fix that.
    Signed-off-by: Dan Williams <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Greg Kroah-Hartman <>
  9. @hmh @gregkh

    rfkill: update LEDs for all state changes

    hmh committed with gregkh
    commit 417bd25 upstream
    The LED state was not being updated by rfkill_force_state(), which
    will cause regressions in wireless drivers that had old-style rfkill
    support and are updated to use rfkill_force_state().
    The LED state was not being updated when a change was detected through
    the rfkill->get_state() hook, either.
    Move the LED trigger update calls into notify_rfkill_state_change(),
    where it should have been in the first place.  This takes care of both
    issues above.
    Signed-off-by: Henrique de Moraes Holschuh <>
    Acked-by: Ivo van Doorn <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Greg Kroah-Hartman <>
  10. @gregkh

    CIFS: make sure we have the right resume info before calling CIFSFind…

    Steve French committed with gregkh
    commit 0752f15 upstream
    When we do a seekdir() or equivalent, we usually end up doing a
    FindFirst call and then call FindNext until we get to the offset that we
    want. The problem is that when we call FindNext, the code usually
    doesn't have the proper info (mostly, the filename of the entry from the
    last search) to resume the search.
    Add a "last_entry" field to the cifs_search_info that points to the last
    entry in the search. We calculate this pointer by using the
    LastNameOffset field from the search parms that are returned. We then
    use that info to do a cifs_save_resume_key before we call CIFSFindNext.
    This patch allows CIFS to reliably pass the "telldir" connectathon test.
    Signed-off-by: Jeff Layton <>
    Signed-off-by: Steve French <>
    Signed-off-by: Greg Kroah-Hartman <>
  11. @gregkh

    tty: Termios locking - sort out real_tty confusions and lock reads

    Alan Cox committed with gregkh
    commit 8f52002 upstream
    (only the tty_io.c portion of this commit)
    This moves us towards sanity and should mean our termios locking is now
    complete and comprehensive.
    Signed-off-by: Alan Cox <>
    Signed-off-by: Linus Torvalds <>
    Signed-off-by: Greg Kroah-Hartman <>
  12. @gregkh

    Fix barrier fail detection in XFS

    Christoph Hellwig committed with gregkh
    commit 73f6aa4 upstream.
    Currently we disable barriers as soon as we get a buffer in xlog_iodone
    that has the XBF_ORDERED flag cleared.  But this can be the case not only
    for buffers where the barrier failed, but also the first buffer of a
    split log write in case of a log wraparound.  Due to the disabled
    barriers we can easily get directory corruption on unclean shutdowns.
    So instead of using this check add a new buffer flag for failed barrier
    This is a regression vs 2.6.26 caused by patch to use the right macro
    to check for the ORDERED flag, as we previously got true returned for
    every buffer.
    Thanks to Toei Rei for reporting the bug.
    Signed-off-by: Christoph Hellwig <>
    Reviewed-by: Eric Sandeen <>
    Reviewed-by: David Chinner <>
    Signed-off-by: Tim Shimmin <>
    Signed-off-by: Linus Torvalds <>
    Signed-off-by: Greg Kroah-Hartman <>
  13. @jmberg @gregkh

    mac80211: fix two issues in debugfs

    jmberg committed with gregkh
    Not in trees above 2.6.27 as it is fixed differently in .28.
    This fixes RHBZ 466264, whenever the master interface is
    renamed this code would BUG_ON. Also fixes a separately
    reported bug with the debugfs dir being NULL.
    This patch is not applicable to the next kernel version
    because both these issues have been fixed, the first one
    by not having the master interface have a ieee80211_ptr
    at all, and the second one by also leaving the function
    Signed-off-by: Johannes Berg <>
    Cc: John Linville <>
    Signed-off-by: Greg Kroah-Hartman <>
  14. @gregkh

    x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap.

    Stefan Bader committed with gregkh
    Not in upstream above 2.6.27 due to change in the way this code works
    (has been fixed differently there.)
    Someone from the community found out, that after repeatedly unloading
    and loading a device driver that uses MSI IRQs, the system eventually
    assigned the vector initially reserved for IRQ0 to the device driver.
    The reason for this is, that although IRQ0 is tied to the
    FIRST_DEVICE_VECTOR when declaring the irq_vector table, the
    corresponding bit in the used_vectors map is not set. So, if vectors are
    released and assigned often enough, the vector will get assigned to
    another interrupt. This happens more often with MSI interrupts as those
    are exclusively using a vector.
    Fix this by setting the bit for the FIRST_DEVICE_VECTOR in the bitmap.
    Signed-off-by: Stefan Bader <>
    Acked-by: Ingo Molnar <>
    Signed-off-by: Greg Kroah-Hartman <>
  15. @fdario @gregkh

    sched_rt.c: resch needed in rt_rq_enqueue() for the root rt_rq

    fdario committed with gregkh
    commit f6121f4 upstream
    While working on the new version of the code for SCHED_SPORADIC I
    noticed something strange in the present throttling mechanism. More
    specifically in the throttling timer handler in sched_rt.c
    (do_sched_rt_period_timer()) and in rt_rq_enqueue().
    The problem is that, when unthrottling a runqueue, rt_rq_enqueue() only
    asks for rescheduling if the runqueue has a sched_entity associated to
    it (i.e., rt_rq->rt_se != NULL).
    Now, if the runqueue is the root rq (which has a rt_se = NULL)
    rescheduling does not take place, and it is delayed to some undefined
    instant in the future.
    This imply some random bandwidth usage by the RT tasks under throttling.
    For instance, setting rt_runtime_us/rt_period_us = 950ms/1000ms an RT
    task will get less than 95%. In our tests we got something varying
    between 70% to 95%.
    Using smaller time values, e.g., 95ms/100ms, things are even worse, and
    I can see values also going down to 20-25%!!
    The tests we performed are simply running 'yes' as a SCHED_FIFO task,
    and checking the CPU usage with top, but we can investigate thoroughly
    if you think it is needed.
    Things go much better, for us, with the attached patch... Don't know if
    it is the best approach, but it solved the issue for us.
    Signed-off-by: Dario Faggioli <>
    Signed-off-by: Michael Trimarchi <>
    Acked-by: Peter Zijlstra <>
    Signed-off-by: Ingo Molnar <>
    Signed-off-by: Greg Kroah-Hartman <>
Commits on Oct 15, 2008
  1. @gregkh


    gregkh committed
  2. @rostedt @gregkh

    disable CONFIG_DYNAMIC_FTRACE due to possible memory corruption on mo…

    rostedt committed with gregkh
    …dule unload
    While debugging the e1000e corruption bug with Intel, we discovered
    today that the dynamic ftrace code in mainline is the likely source of
    this bug.
    For the stable kernel we are providing the only viable fix patch: labeling
    CONFIG_DYNAMIC_FTRACE as broken. (see the patch below)
    We will follow up with a backport patch that contains the fixes. But since
    the fixes are not a one liner, the safest approach for now is to
    disable the code in question.
    The cause of the bug is due to the way the current code in mainline
    handles dynamic ftrace.  When dynamic ftrace is turned on, it also
    turns on CONFIG_FTRACE which enables the -pg config in gcc that places
    a call to mcount at every function call. With just CONFIG_FTRACE this
    causes a noticeable overhead.  CONFIG_DYNAMIC_FTRACE works to ease this
    overhead by dynamically updating the mcount call sites into nops.
    The problem arises when we trace functions and modules are unloaded.
    The first time a function is called, it will call mcount and the mcount
    call will call ftrace_record_ip. This records the calling site and
    stores it in a preallocated hash table. Later on a daemon will
    wake up and call kstop_machine and convert any mcount callers into
    The evolution of this code first tried to do this without the kstop_machine
    and used cmpxchg to update the callers as they were called. But I
    was informed that this is dangerous to do on SMP machines if another
    CPU is running that same code. The solution was to do this with
    We still used cmpxchg to test if the code that we are modifying is
    indeed code that we expect to be before updating it - as a final
    line of defense.
    But on 32bit machines, ioremapped memory and modules share the same
    address space. When a module would load its code into memory and execute
    some code, that would register the function.
    On module unload, ftrace incorrectly did not zap these functions from
    its hash (this was the bug). The cmpxchg could have saved us in most
    cases (via luck) - but with ioremap-ed memory that was exactly the wrong
    thing to do - the results of cmpxchg on device memory are undefined.
    (and will likely result in a write)
    The pending .28 ftrace tree does not have this bug anymore, as a general push
    towards more robustness of code patching, this is done differently: we do not
    use cmpxchg and we do a WARN_ON and turn the tracer off if anything deviates
    from its expected state. Furthermore, patch sites are statically identified
    during build time so there's no runtime discovery of dynamic code areas
    anymore, and no room for code unmaps to cause the hash to become out of date.
    We believe the fragility of dynamic patching has been sufficiently
    addressed in the development code via the static patching method, but further
    suggestions to make it more robust are welcome.
    Signed-off-by: Steven Rostedt <>
    Acked-by: Ingo Molnar <>
    Acked-by: Thomas Gleixner <>
    Signed-off-by: Greg Kroah-Hartman <>
Commits on Oct 9, 2008
  1. @torvalds

    Linux 2.6.27

    torvalds committed
  2. @torvalds

    Don't allow splice() to files opened with O_APPEND

    torvalds committed
    This is debatable, but while we're debating it, let's disallow the
    combination of splice and an O_APPEND destination.
    It's not entirely clear what the semantics of O_APPEND should be, and
    POSIX apparently expects pwrite() to ignore O_APPEND, for example.  So
    we could make up any semantics we want, including the old ones.
    But Miklos convinced me that we should at least give it some thought,
    and that accepting writes at arbitrary offsets is wrong at least for
    IS_APPEND() files (which always have O_APPEND set, even if the reverse
    isn't true: you can obviously have O_APPEND set on a regular file).
    So disallow O_APPEND entirely for now.  I doubt anybody cares, and this
    way we have one less gray area to worry about.
    Reported-and-argued-for-by: Miklos Szeredi <>
    Acked-by: Jens Axboe <>
    Signed-off-by: Linus Torvalds <>
  3. @torvalds

    Merge branch 'hwmon-for-linus' of git://…

    torvalds committed
    * 'hwmon-for-linus' of git://
      hwmon: (abituguru3) Enable DMI probing feature on Abit AT8 32X
      hwmon: (abituguru3) Enable reading from AUX3 fan on Abit AT8 32X
      hwmon: (adt7473) Fix some bogosity in documentation file
      hwmon: Define sysfs interface for energy consumption register
      hwmon: (it87) Prevent power-off on Shuttle SN68PT
      eeepc-laptop: Fix hwmon interface
  4. @torvalds

    Merge branch 'fixes' of git://…

    torvalds committed
    * 'fixes' of git://
      [CPUFREQ] correct broken links and email addresses
  5. @torvalds

    SLOB: fix bogus ksize calculation fix

    Matt Mackall committed with torvalds
    This fixes the previous fix, which was completely wrong on closer
    inspection. This version has been manually tested with a user-space
    test harness and generates sane values. A nearly identical patch has
    been boot-tested.
    The problem arose from changing how kmalloc/kfree handled alignment
    padding without updating ksize to match. This brings it in sync.
    Signed-off-by: Matt Mackall <>
    Signed-off-by: Linus Torvalds <>
  6. @kernelslacker

    [CPUFREQ] correct broken links and email addresses

    Németh Márton committed with kernelslacker
    Replace the no longer working links and email address in the
    documentation and in source code.
    Signed-off-by: Márton Németh <>
    Signed-off-by: Dave Jones <>
  7. @ajs1984

    hwmon: (abituguru3) Enable DMI probing feature on Abit AT8 32X

    ajs1984 committed with Jean Delvare
    Enable driver checking of the DMI product name (when enabled) on
    an Abit AT8 32X, instead of falling back to a manual probe. This
    eliminates false negatives and eventually will help avoid
    unnecessary bus probes on unsupported mainboards.
    Signed-off-by: Alistair John Strachan <>
    Tested-by: Daniel Exner <>
    Acked-by: Hans de Goede <>
    Signed-off-by: Jean Delvare <>
  8. @ajs1984

    hwmon: (abituguru3) Enable reading from AUX3 fan on Abit AT8 32X

    ajs1984 committed with Jean Delvare
    The table for the Abit AT8 32X was incorrectly missing an entry
    for the sixth ("AUX3") fan. Add this entry, exporting the fan
    reading to userspace.
    Closes ticket #2339.
    Signed-off-by: Alistair John Strachan <>
    Tested-by: Daniel Exner <>
    Acked-by: Hans de Goede <>
    Signed-off-by: Jean Delvare <>
  9. hwmon: (adt7473) Fix some bogosity in documentation file

    Darrick J. Wong committed with Jean Delvare
    Signed-off-by: Darrick J. Wong <>
    Signed-off-by: Jean Delvare <>
  10. hwmon: Define sysfs interface for energy consumption register

    Darrick J. Wong committed with Jean Delvare
    Describe the sysfs files that were introduced in the ibmaem driver.
    Signed-off-by: Darrick J. Wong <>
    Signed-off-by: Jean Delvare <>
  11. hwmon: (it87) Prevent power-off on Shuttle SN68PT

    Jean Delvare committed with Jean Delvare
    On the Shuttle SN68PT, FAN_CTL2 is apparently not connected to a fan,
    but to something else. One user has reported instant system power-off
    when changing the PWM2 duty cycle, so we disable it.
    I use the board name string as the trigger in case the same board is
    ever used in other systems.
    This closes lm-sensors ticket #2349:
    pwmconfig causes a hard poweroff
    Signed-off-by: Jean Delvare <>
  12. @iksaif

    eeepc-laptop: Fix hwmon interface

    iksaif committed with Jean Delvare
    Creates a name file in the sysfs directory, that
    is needed for the libsensors library to work.
    Also rename fan1_pwm to pwm1 and scale its value as needed.
    This fixes bug #11520:
    Signed-off-by: Corentin Chary <>
    Signed-off-by: Jean Delvare <>
Commits on Oct 8, 2008
  1. @torvalds

    Merge branch 'upstream' of git://…

    torvalds committed
    * 'upstream' of git://
      [MIPS] Sibyte: Register PIO PATA device only for Swarm and Litte Sur
  2. @torvalds

    Merge git://

    torvalds committed
    * git://
      tcp: Fix tcp_hybla zero congestion window growth with small rho and large cwnd.
      net: Fix netdev_run_todo dead-lock
      tcp: Fix possible double-ack w/ user dma
      net: only invoke dev->change_rx_flags when device is UP
      netrom: Fix sock_orphan() use in nr_release
      ax25: Quick fix for making sure unaccepted sockets get destroyed.
      Revert "ax25: Fix std timer socket destroy handling."
      [Bluetooth] Add reset quirk for A-Link BlueUSB21 dongle
      [Bluetooth] Add reset quirk for new Targus and Belkin dongles
      [Bluetooth] Fix double frees on error paths of btusb and bpa10x drivers
  3. @ralfbaechle

    [MIPS] Sibyte: Register PIO PATA device only for Swarm and Litte Sur

    ralfbaechle committed
    Symbol name spaghetti which is too complicated to cleanup on this stage
    of the release cycle breaks the build on BCM1480 platforms.
    Signed-off-by: Ralf Baechle <>
Commits on Oct 7, 2008
  1. @danielinux @davem330

    tcp: Fix tcp_hybla zero congestion window growth with small rho and l…

    danielinux committed with davem330
    …arge cwnd.
    Because of rounding, in certain conditions, i.e. when in congestion
    avoidance state rho is smaller than 1/128 of the current cwnd, TCP
    Hybla congestion control starves and the cwnd is kept constant
    This patch forces an increment by one segment after #send_cwnd calls
    without increments(newreno behavior).
    Signed-off-by: Daniele Lacamera <>
    Signed-off-by: David S. Miller <>
  2. @herbertx @davem330

    net: Fix netdev_run_todo dead-lock

    herbertx committed with davem330
    Benjamin Thery tracked down a bug that explains many instances
    of the error
    unregister_netdevice: waiting for %s to become free. Usage count = %d
    It turns out that netdev_run_todo can dead-lock with itself if
    a second instance of it is run in a thread that will then free
    a reference to the device waited on by the first instance.
    The problem is really quite silly.  We were trying to create
    parallelism where none was required.  As netdev_run_todo always
    follows a RTNL section, and that todo tasks can only be added
    with the RTNL held, by definition you should only need to wait
    for the very ones that you've added and be done with it.
    There is no need for a second mutex or spinlock.
    This is exactly what the following patch does.
    Signed-off-by: Herbert Xu <>
    Signed-off-by: David S. Miller <>
  3. @davem330
Something went wrong with that request. Please try again.