Skip to content
Commits on Jan 18, 2010
  1. @gregkh

    Linux 2.6.31.12

    gregkh committed Jan 18, 2010
  2. @lenb @gregkh

    ACPI: DMI init_set_sci_en_on_resume for HP-Compaq C700

    commit 87c687b upstream.
    
    ...else ACPI thermal controls fail after resume.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=13745
    
    Signed-off-by: Len Brown <len.brown@intel.com>
    Cc: Stefan Bader <stefan.bader@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    lenb committed with gregkh Nov 23, 2009
  3. @gregkh

    ACPI: sleep: another HP/Compaq DMI entries for init_set_sci_en_on_resume

    commit 2839d39 upstream.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=13745
    
    Signed-off-by: Len Brown <len.brown@intel.com>
    Cc: Stefan Bader <stefan.bader@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Vaibhav Verma committed with gregkh Nov 5, 2009
  4. @gregkh

    ACPI: add DMI entry for SCI_EN resume quirk on HP dv4

    commit 8a1cbf6 upstream.
    
    Fixes the missing battery on sleep problem for yet another HP laptop
    ("HP Pavilion dv4").
    
    Fixes:
    	http://bugzilla.kernel.org/show_bug.cgi?id=13449
    
    Signed-off-by: Gustavo Maciel Dias Vieira <gustavo@sagui.org>
    Signed-off-by: Len Brown <len.brown@intel.com>
    Cc: Stefan Bader <stefan.bader@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Gustavo Maciel Dias Vieira committed with gregkh Oct 19, 2009
  5. @lenb @gregkh

    ACPI: sleep: another HP DMI entry for init_set_sci_en_on_resume

    commit eb0ca84 upstream.
    
    DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv3 Notebook PC")
    
    http://bugzilla.kernel.org/show_bug.cgi?id=13745
    
    Signed-off-by: Len Brown <len.brown@intel.com>
    Cc: Stefan Bader <stefan.bader@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    lenb committed with gregkh Aug 29, 2009
  6. @davem330 @gregkh

    ipv6: skb_dst() can be NULL in ipv6_hop_jumbo().

    commit 2570a4f upstream.
    
    This fixes CERT-FI FICORA #341748
    
    Discovered by Olli Jarva and Tuomo Untinen from the CROSS
    project at Codenomicon Ltd.
    
    Just like in CVE-2007-4567, we can't rely upon skb_dst() being
    non-NULL at this point.  We fixed that in commit
    e76b2b2 ("[IPV6]: Do no rely on
    skb->dst before it is assigned.")
    
    However commit 483a47d ("ipv6: added
    net argument to IP6_INC_STATS_BH") put a new version of the same bug
    into this function.
    
    Complicating analysis further, this bug can only trigger when network
    namespaces are enabled in the build.  When namespaces are turned off,
    the dev_net() does not evaluate it's argument, so the dereference
    would not occur.
    
    So, for a long time, namespaces couldn't be turned on unless SYSFS was
    disabled.  Therefore, this code has largely been disabled except by
    people turning it on explicitly for namespace development.
    
    With help from Eugene Teo <eugene@redhat.com>
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    davem330 committed with gregkh Jan 13, 2010
  7. @gregkh

    fix more leaks in audit_tree.c tag_chunk()

    commit b4c30aa upstream.
    
    Several leaks in audit_tree didn't get caught by commit
    318b6d3, including the leak on normal
    exit in case of multiple rules refering to the same chunk.
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Al Viro committed with gregkh Dec 19, 2009
  8. @gregkh

    fix braindamage in audit_tree.c untag_chunk()

    commit 6f5d511 upstream.
    
    ... aka "Al had badly fscked up when writing that thing and nobody
    noticed until Eric had fixed leaks that used to mask the breakage".
    
    The function essentially creates a copy of old array sans one element
    and replaces the references to elements of original (they are on cyclic
    lists) with those to corresponding elements of new one.  After that the
    old one is fair game for freeing.
    
    First of all, there's a dumb braino: when we get to list_replace_init we
    use indices for wrong arrays - position in new one with the old array
    and vice versa.
    
    Another bug is more subtle - termination condition is wrong if the
    element to be excluded happens to be the last one.  We shouldn't go
    until we fill the new array, we should go until we'd finished the old
    one.  Otherwise the element we are trying to kill will remain on the
    cyclic lists...
    
    That crap used to be masked by several leaks, so it was not quite
    trivial to hit.  Eric had fixed some of those leaks a while ago and the
    shit had hit the fan...
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Al Viro committed with gregkh Dec 19, 2009
  9. @jankara @gregkh

    quota: Fix dquot_transfer for filesystems different from ext4

    commit 05b5d89 upstream.
    
    Commit fd8fbfc modified the way we find amount of reserved space
    belonging to an inode. The amount of reserved space is checked
    from dquot_transfer and thus inode_reserved_space gets called
    even for filesystems that don't provide get_reserved_space callback
    which results in a BUG.
    
    Fix the problem by checking get_reserved_space callback and return 0 if
    the filesystem does not provide it.
    
    CC: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jankara committed with gregkh Jan 6, 2010
  10. @kaber @gregkh

    netfilter: nf_ct_ftp: fix out of bounds read in update_nl_seq()

    commit aaff23a upstream.
    
    As noticed by Dan Carpenter <error27@gmail.com>, update_nl_seq()
    currently contains an out of bounds read of the seq_aft_nl array
    when looking for the oldest sequence number position.
    
    Fix it to only compare valid positions.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    kaber committed with gregkh Jan 7, 2010
  11. @gregkh

    netfilter: ebtables: enforce CAP_NET_ADMIN

    commit dce766a upstream.
    
    normal users are currently allowed to set/modify ebtables rules.
    Restrict it to processes with CAP_NET_ADMIN.
    
    Note that this cannot be reproduced with unmodified ebtables binary
    because it uses SOCK_RAW.
    
    Signed-off-by: Florian Westphal <fwestphal@astaro.com>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Florian Westphal committed with gregkh Jan 8, 2010
  12. @gregkh

    kernel/signal.c: fix kernel information leak with print-fatal-signals=1

    commit b45c6e7 upstream.
    
    When print-fatal-signals is enabled it's possible to dump any memory
    reachable by the kernel to the log by simply jumping to that address from
    user space.
    
    Or crash the system if there's some hardware with read side effects.
    
    The fatal signals handler will dump 16 bytes at the execution address,
    which is fully controlled by ring 3.
    
    In addition when something jumps to a unmapped address there will be up to
    16 additional useless page faults, which might be potentially slow (and at
    least is not very efficient)
    
    Fortunately this option is off by default and only there on i386.
    
    But fix it by checking for kernel addresses and also stopping when there's
    a page fault.
    
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Andi Kleen committed with gregkh Jan 8, 2010
  13. @gregkh

    hwmon: (adt7462) Fix pin 28 monitoring

    commit bb595c9 upstream.
    
    The ADT7462_PIN28_VOLT value is a 4-bit field, so the corresponding
    shift must be 4.
    
    Signed-off-by: Roger Blofeld <blofeldus@yahoo.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Roger Blofeld committed with gregkh Jan 10, 2010
  14. @torvalds @gregkh

    fasync: split 'fasync_helper()' into separate add/remove functions

    commit 53281b6 upstream.
    
    Yes, the add and remove cases do share the same basic loop and the
    locking, but the compiler can inline and then CSE some of the end result
    anyway.  And splitting it up makes the code way easier to follow,
    and makes it clearer exactly what the semantics are.
    
    In particular, we must make sure that the FASYNC flag in file->f_flags
    exactly matches the state of "is this file on any fasync list", since
    not only is that flag visible to user space (F_GETFL), but we also use
    that flag to check whether we need to remove any fasync entries on file
    close.
    
    We got that wrong for the case of a mixed use of file locking (which
    tries to remove any fasync entries for file leases) and fasync.
    
    Splitting the function up also makes it possible to do some future
    optimizations without making the function even messier.  In particular,
    since the FASYNC flag has to match the state of "is this on a list", we
    can do the following future optimizations:
    
     - on remove, we don't even need to get the locks and traverse the list
       if FASYNC isn't set, since we can know a priori that there is no
       point (this is effectively the same optimization that we already do
       in __fput() wrt removing fasync on file close)
    
     - on add, we can use the FASYNC flag to decide whether we are changing
       an existing entry or need to allocate a new one.
    
    but this is just the cleanup + fix for the FASYNC flag.
    
    Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
    Tested-by: Tavis Ormandy <taviso@google.com>
    Cc: Jeff Dike <jdike@addtoit.com>
    Cc: Matt Mackall <mpm@selenic.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    torvalds committed with gregkh Dec 16, 2009
Commits on Jan 7, 2010
  1. @gregkh

    Linux 2.6.31.11

    gregkh committed Jan 7, 2010
  2. @gregkh

    Revert "rt2x00: Disable powersaving for rt61pci and rt2800pci."

    This reverts commit f1850a5.
    
    It broke the build :(
    
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    gregkh committed Jan 7, 2010
Commits on Jan 6, 2010
  1. @gregkh

    Linux 2.6.31.10

    gregkh committed Jan 6, 2010
  2. @dmonakhov @gregkh

    ext4: fix sleep inside spinlock issue with quota and dealloc (#14739)

    commit 39bc680 upstream.
    
    Unlock i_block_reservation_lock before vfs_dq_reserve_block().
    This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=14739
    
    Cc: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    dmonakhov committed with gregkh Dec 10, 2009
  3. @dmonakhov @gregkh

    ext4: Convert to generic reserved quota's space management.

    commit a9e7f44 upstream.
    
    This patch also fixes write vs chown race condition.
    
    Acked-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    dmonakhov committed with gregkh Dec 14, 2009
  4. @dmonakhov @gregkh

    quota: decouple fs reserved space from quota reservation

    commit fd8fbfc upstream.
    
    Currently inode_reservation is managed by fs itself and this
    reservation is transfered on dquot_transfer(). This means what
    inode_reservation must always be in sync with
    dquot->dq_dqb.dqb_rsvspace. Otherwise dquot_transfer() will result
    in incorrect quota(WARN_ON in dquot_claim_reserved_space() will be
    triggered)
    This is not easy because of complex locking order issues
    for example http://bugzilla.kernel.org/show_bug.cgi?id=14739
    
    The patch introduce quota reservation field for each fs-inode
    (fs specific inode is used in order to prevent bloating generic
    vfs inode). This reservation is managed by quota code internally
    similar to i_blocks/i_bytes and may not be always in sync with
    internal fs reservation.
    
    Also perform some code rearrangement:
    - Unify dquot_reserve_space() and dquot_reserve_space()
    - Unify dquot_release_reserved_space() and dquot_free_space()
    - Also this patch add missing warning update to release_rsv()
      dquot_release_reserved_space() must call flush_warnings() as
      dquot_free_space() does.
    
    Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    dmonakhov committed with gregkh Dec 14, 2009
  5. @dmonakhov @gregkh

    Add unlocked version of inode_add_bytes() function

    commit b462707 upstream.
    
    Quota code requires unlocked version of this function. Off course
    we can just copy-paste the code, but copy-pasting is always an evil.
    
    Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    dmonakhov committed with gregkh Dec 14, 2009
  6. @Codeblight @gregkh

    Input: atkbd - add force relese key quirk for Samsung R59P/R60P/R61P

    This patch is not upstream. Since 2.6.32, there is an interface in
    /sys for handling the force_release events from userspace, so such
    quirk patches are no longer accepted upstream now. But this patch is
    valid for version 2.6.31 downwards.
    
    OriginalAuthor:
        Moiseev Vladimir <cdb@linkycat.com>
        Alexander Huhlaev <sancheolz@gmail.com>
    
    BugLink: http://bugs.launchpad.net/bugs/253874
    
    Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
    Cc: Moiseev Vladimir <cdb@linkycat.com>
    Cc: Alexander Huhlaev <sancheolz@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Codeblight committed with gregkh Dec 7, 2009
  7. @gregkh

    memcg: avoid oom-killing innocent task in case of use_hierarchy

    commit d31f56d upstream
    
    task_in_mem_cgroup(), which is called by select_bad_process() to check whether
    a task can be a candidate for being oom-killed from memcg's limit, checks
    "curr->use_hierarchy"("curr" is the mem_cgroup the task belongs to).
    
    But this check return true(it's false positive) when:
    
    	<some path>/00		use_hierarchy == 0	<- hitting limit
    	  <some path>/00/aa	use_hierarchy == 1	<- "curr"
    
    This leads to killing an innocent task in 00/aa. This patch is a fix for this
    bug. And this patch also fixes the arg for mem_cgroup_print_oom_info(). We
    should print information of mem_cgroup which the task being killed, not current,
    belongs to.
    
    Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
    Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Reviewed-by: Balbir Singh <balbir@linux.vnet.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Daisuke Nishimura committed with gregkh Jan 5, 2010
  8. @gregkh

    rt2x00: Disable powersaving for rt61pci and rt2800pci.

    commit 93b6bd2 upstream.
    
    We've had many reports of rt61pci failures with powersaving enabled.
    Therefore, as a stop-gap measure, disable powersaving of the rt61pci
    until we have found a proper solution.
    Also disable powersaving on rt2800pci as it most probably will show
    the same problem.
    
    Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
    Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Gertjan van Wingerde committed with gregkh Dec 14, 2009
  9. @gregkh

    generic_permission: MAY_OPEN is not write access

    commit 7ea6600 upstream.
    
    generic_permission was refusing CAP_DAC_READ_SEARCH-enabled
    processes from opening DAC-protected files read-only, because
    do_filp_open adds MAY_OPEN to the open mask.
    
    Ignore MAY_OPEN.  After this patch, CAP_DAC_READ_SEARCH is
    again sufficient to open(fname, O_RDONLY) on a file to which
    DAC otherwise refuses us read permission.
    
    Reported-by: Mike Kazantsev <mk.fraggod@gmail.com>
    Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
    Tested-by: Mike Kazantsev <mk.fraggod@gmail.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Serge E. Hallyn committed with gregkh Dec 29, 2009
  10. @janekr @gregkh

    XFS bug in log recover with quota (bugzilla id 855)

    commit 8ec6dba upstream.
    
    Hi,
    I was hit by a bug in linux 2.6.31 when XFS is not able to recover the
    log after a crash if fs was mounted with quotas. Gory details in XFS
    bugzilla: http://oss.sgi.com/bugzilla/show_bug.cgi?id=855.
    
    It looks like wrong struct is used in buffer length check, and the following
    patch should fix the problem.
    
    xfs_dqblk_t has a size of 104+32 bytes, while xfs_disk_dquot_t is 104 bytes
    long, and this is exactly what I see in system logs - "XFS: dquot too small
    (104) in xlog_recover_do_dquot_trans."
    
    Signed-off-by: Jan Rekorajski <baggins@sith.mimuw.edu.pl>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Alex Elder <aelder@sgi.com>
    Cc: Simon Kirby <sim@hostway.ca>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    janekr committed with gregkh Nov 16, 2009
  11. @torvalds @gregkh

    x86/ptrace: make genregs[32]_get/set more robust

    commit 04a1e62 upstream.
    
    The loop condition is fragile: we compare an unsigned value to zero, and
    then decrement it by something larger than one in the loop.  All the
    callers should be passing in appropriately aligned buffer lengths, but
    it's better to just not rely on it, and have some appropriate defensive
    loop limits.
    
    Acked-by: Roland McGrath <roland@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    torvalds committed with gregkh Dec 17, 2009
  12. @error27 @gregkh

    V4L/DVB (13596): ov511.c typo: lock => unlock

    commit 50e9d31 upstream.
    
    This was found with a static checker and has not been tested, but it seems
    pretty clear that the mutex_lock() was supposed to be mutex_unlock()
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Cc: Brandon Philips <brandon@ifup.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    error27 committed with gregkh Dec 10, 2009
  13. @jankara @gregkh

    udf: Try harder when looking for VAT inode

    commit e971b0b upstream.
    
    Some disks do not contain VAT inode in the last recorded block as required
    by the standard but a few blocks earlier (or the number of recorded blocks
    is wrong). So look for the VAT inode a bit before the end of the media.
    
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jankara committed with gregkh Nov 30, 2009
  14. @gregkh

    S390: dasd: support DIAG access for read-only devices

    commit 22825ab upstream.
    
    When a DASD device is used with the DIAG discipline, the DIAG
    initialization will indicate success or error with a respective
    return code. So far we have interpreted a return code of 4 as error,
    but it actually means that the initialization was successful, but
    the device is read-only. To allow read-only devices to be used with
    DIAG we need to accept a return code of 4 as success.
    
    Re-initialization of the DIAG access is also part of the DIAG error
    recovery. If we find that the access mode of a device has been
    changed from writable to read-only while the device was in use,
    we print an error message.
    
    Signed-off-by: Stefan Weinhuber <wein@de.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Cc: Stephen Powell <zlinuxman@wowway.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Stefan Weinhuber committed with gregkh Dec 7, 2009
  15. @kaber @gregkh

    ipv6: reassembly: use seperate reassembly queues for conntrack and lo…

    …cal delivery
    
    commit 0b5ccb2 upstream.
    
    Currently the same reassembly queue might be used for packets reassembled
    by conntrack in different positions in the stack (PREROUTING/LOCAL_OUT),
    as well as local delivery. This can cause "packet jumps" when the fragment
    completing a reassembled packet is queued from a different position in the
    stack than the previous ones.
    
    Add a "user" identifier to the reassembly queue key to seperate the queues
    of each caller, similar to what we do for IPv4.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    kaber committed with gregkh Dec 15, 2009
  16. @gregkh

    i2c/tsl2550: Fix lux value in extended mode

    commit 5f5bfb0 upstream.
    
    According to the TAOS Application Note 'Controlling a Backlight with
    the TSL2550 Ambient Light Sensor' (page 14), the actual lux value in
    extended mode should be obtained multiplying the calculated lux value
    by 5.
    
    Signed-off-by: Michele Jr De Candia <michele.decandia@valueteam.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Michele Jr De Candia committed with gregkh Nov 26, 2009
  17. @gregkh

    hwmon: (sht15) Off-by-one error in array index + incorrect constants

    commit 4235f68 upstream.
    
    Fix an off-by-one error in array index + incorrect constants.
    
    Signed-off-by: Christoph Walser <walser@tik.ee.ethz.ch>
    Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jonathan Cameron committed with gregkh Dec 16, 2009
  18. @RoelKluin @gregkh

    hwmon: (fschmd) Fix check on unsigned in watchdog_write()

    commit c7702c3 upstream.
    
    If unsigned the watchdog_trigger() return value will not be
    checked correctly.
    
    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    Acked-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    RoelKluin committed with gregkh Oct 24, 2009
  19. @martin-decky @gregkh

    hostap: Revert a toxic part of the conversion to net_device_ops

    commit e484c16 upstream.
    
    As the hostap driver was converted to use net_device_ops, a mistake was
    made in hostap_main.c (commit 5ae4efb).
    Originally, the tx_queue_len was set to 0 for every other interface than
    HOSTAP_INTERFACE_MASTER, but the new fragment of code sets tx_queue_len to
    0 only for HOSTAP_INTERFACE_MASTER. The opposite of the previous
    behavior makes the driver to drop all packets in AP mode.
    
    Change the way 0 is assigned to tx_queue_len according to the original
    logic.
    
    Signed-off-by: Martin Decky <martin@decky.cz>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    martin-decky committed with gregkh Sep 10, 2009
Something went wrong with that request. Please try again.