Skip to content
Commits on Nov 7, 2011
  1. @gregkh

    Linux 2.6.33.20

    gregkh committed Nov 7, 2011
  2. @tytso @gregkh

    ext2,ext3,ext4: don't inherit APPEND_FL or IMMUTABLE_FL for new inodes

    commit 1cd9f09 upstream.
    
    This doesn't make much sense, and it exposes a bug in the kernel where
    attempts to create a new file in an append-only directory using
    O_CREAT will fail (but still leave a zero-length file).  This was
    discovered when xfstests #79 was generalized so it could run on all
    file systems.
    
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    tytso committed with gregkh Aug 31, 2011
  3. @abou9 @gregkh

    drivers/net/rionet.c: fix ethernet address macros for LE platforms

    commit e0c87bd upstream.
    
    Modify Ethernet addess macros to be compatible with BE/LE platforms
    
    Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
    Cc: Chul Kim <chul.kim@idt.com>
    Cc: Kumar Gala <galak@kernel.crashing.org>
    Cc: Matt Porter <mporter@kernel.crashing.org>
    Cc: Li Yang <leoli@freescale.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    abou9 committed with gregkh Nov 2, 2011
  4. @gnehzuil @gregkh

    ext4: fix BUG_ON() in ext4_ext_insert_extent()

    Does not corrispond with a direct commit in Linus's tree as it was fixed
    differently in the 3.0 release.
    
    
    We will meet with a BUG_ON() if following script is run.
    
    mkfs.ext4 -b 4096 /dev/sdb1 1000000
    mount -t ext4 /dev/sdb1 /mnt/sdb1
    fallocate -l 100M /mnt/sdb1/test
    sync
    for((i=0;i<170;i++))
    do
            dd if=/dev/zero of=/mnt/sdb1/test conv=notrunc bs=256k count=1
    seek=`expr $i \* 2`
    done
    umount /mnt/sdb1
    mount -t ext4 /dev/sdb1 /mnt/sdb1
    dd if=/dev/zero of=/mnt/sdb1/test conv=notrunc bs=256k count=1 seek=341
    umount /mnt/sdb1
    mount /dev/sdb1 /mnt/sdb1
    dd if=/dev/zero of=/mnt/sdb1/test conv=notrunc bs=256k count=1 seek=340
    sync
    
    The reason is that it forgot to mark dirty when splitting two extents in
    ext4_ext_convert_to_initialized(). Althrough ex has been updated in
    memory, it is not dirtied both in ext4_ext_convert_to_initialized() and
    ext4_ext_insert_extent(). The disk layout is corrupted. Then it will
    meet with a BUG_ON() when writting at the start of that extent again.
    
    Cc: "Theodore Ts'o" <tytso@mit.edu>
    Cc: Xiaoyun Mao <xiaoyun.maoxy@aliyun-inc.com>
    Cc: Yingbin Wang <yingbin.wangyb@aliyun-inc.com>
    Cc: Jia Wan <jia.wanj@aliyun-inc.com>
    Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    gnehzuil committed with gregkh Oct 28, 2011
  5. @gregkh

    net_sched: Fix qdisc_notify()

    commit 53b0f08 upstream.
    
    Ben Pfaff reported a kernel oops and provided a test program to
    reproduce it.
    
    https://kerneltrap.org/mailarchive/linux-netdev/2010/5/21/6277805
    
    tc_fill_qdisc() should not be called for builtin qdisc, or it
    dereference a NULL pointer to get device ifindex.
    
    Fix is to always use tc_qdisc_dump_ignore() before calling
    tc_fill_qdisc().
    
    Reported-by: Ben Pfaff <blp@nicira.com>
    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Eric Dumazet committed with gregkh May 22, 2010
  6. @gregkh

    nl80211: fix overflow in ssid_len

    commit 57a27e1 upstream.
    
    When one of the SSID's length passed in a scan or sched_scan request
    is larger than 255, there will be an overflow in the u8 that is used
    to store the length before checking.  This causes the check to fail
    and we overrun the buffer when copying the SSID.
    
    Fix this by checking the nl80211 attribute length before copying it to
    the struct.
    
    This is a follow up for the previous commit
    208c72f, which didn't fix the problem
    entirely.
    
    Reported-by: Ido Yariv <ido@wizery.com>
    Signed-off-by: Luciano Coelho <coelho@ti.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Luciano Coelho committed with gregkh Jun 7, 2011
  7. @gregkh

    Bluetooth: Prevent buffer overflow in l2cap config request

    commit 7ac2881 upstream.
    
    A remote user can provide a small value for the command size field in
    the command header of an l2cap configuration request, resulting in an
    integer underflow when subtracting the size of the configuration request
    header.  This results in copying a very large amount of data via
    memcpy() and destroying the kernel heap.  Check for underflow.
    
    Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
    Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Dan Rosenberg committed with gregkh Jun 24, 2011
  8. @gregkh

    vm: fix vm_pgoff wrap in upward expansion

    commit 42c36f6 upstream.
    
    Commit a626ca6 ("vm: fix vm_pgoff wrap in stack expansion") fixed
    the case of an expanding mapping causing vm_pgoff wrapping when you had
    downward stack expansion.  But there was another case where IA64 and
    PA-RISC expand mappings: upward expansion.
    
    This fixes that case too.
    
    Signed-off-by: Hugh Dickins <hughd@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Hugh Dickins committed with gregkh May 9, 2011
  9. @torvalds @gregkh

    vm: fix vm_pgoff wrap in stack expansion

    commit a626ca6 upstream.
    
    Commit 982134b ("mm: avoid wrapping vm_pgoff in mremap()") fixed
    the case of a expanding mapping causing vm_pgoff wrapping when you used
    mremap.  But there was another case where we expand mappings hiding in
    plain sight: the automatic stack expansion.
    
    This fixes that case too.
    
    This one also found by Robert Święcki, using his nasty system call
    fuzzer tool.  Good job.
    
    Reported-and-tested-by: Robert Święcki <robert@swiecki.net>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    torvalds committed with gregkh Apr 13, 2011
  10. @gregkh

    Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.

    commit 8d03e97 upstream.
    
    Structures "l2cap_conninfo" and "rfcomm_conninfo" have one padding
    byte each. This byte in "cinfo" is copied to userspace uninitialized.
    
    Signed-off-by: Filip Palian <filip.palian@pjwstk.edu.pl>
    Acked-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Filip Palian committed with gregkh May 12, 2011
  11. @gregkh

    NLM: Don't hang forever on NLM unlock requests

    commit 0b76011 upstream.
    
    If the NLM daemon is killed on the NFS server, we can currently end up
    hanging forever on an 'unlock' request, instead of aborting. Basically,
    if the rpcbind request fails, or the server keeps returning garbage, we
    really want to quit instead of retrying.
    
    Tested-by: Vasily Averin <vvs@sw.ru>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Trond Myklebust committed with gregkh May 31, 2011
  12. @gregkh

    scm: lower SCM_MAX_FD

    commit bba14de upstream.
    
    Lower SCM_MAX_FD from 255 to 253 so that allocations for scm_fp_list are
    halved. (commit f8d570a added two pointers in this structure)
    
    scm_fp_dup() should not copy whole structure (and trigger kmemcheck
    warnings), but only the used part. While we are at it, only allocate
    needed size.
    
    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Eric Dumazet committed with gregkh Nov 23, 2010
  13. @gregkh

    thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

    commit 9fbdaeb upstream.
    
    The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead
    of IBM0068. Added new HID so that thinkpad_acpi module will
    auto load on these newer Lenovo ThinkPads.
    
    Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
    Cc: stable@vger.kernel.org
    Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
    Signed-off-by: Andy Lutomirski <luto@mit.edu>
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Bjørn Mork <bjorn@mork.no>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Manoj Iyer committed with gregkh Oct 20, 2011
  14. @error27 @gregkh

    kcore: fix test for end of list

    commit 4fd2c20 upstream.
    
    "m" is never NULL here.  We need a different test for the end of list
    condition.
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Leonardo Chiquitto <leonardo.lists@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    error27 committed with gregkh Mar 23, 2010
  15. @ffainelli @gregkh

    watchdog: mtx1-wdt: fix build failure

    Commit 72b6e8a (watchdog: mtx1-wdt: request gpio before using it) was
    backported from upstream. The patch is using a gpiolib call which is only
    available in kernel 2.6.34+. Fix build by using the "old" gpiolib API
    instead.
    
    Signed-off-by: Florian Fainelli <florian@openwrt.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ffainelli committed with gregkh Oct 17, 2011
  16. @gregkh

    Revert "usb: musb: restore INDEX register in resume path"

    This reverts commit 5aa8a93.
    
    Turns out this breaks the build, and as such, really isn't needed for
    the 2.6.33-stable branch at all.
    
    Reported-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
    Cc: Anand Gadiyar <gadiyar@ti.com>
    Cc: Ajay Kumar Gupta <ajay.gupta@ti.com>
    Cc: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    gregkh committed Nov 2, 2011
  17. @ffainelli @gregkh

    Revert "MIPS: MTX-1: Make au1000_eth probe all PHY

    Commit 34dce55 was not applicable in 2.6.33 and introduces a build breakage.
    Revert that commit since it is irrelevant for this kernel version.
    
    Acked-by: Ralf Baechle <ralf@linux-mips.org>
    Signed-off-by: Florian Fainelli <florian@openwrt.org>
    ffainelli committed with gregkh Oct 17, 2011
  18. @gregkh

    gro: Re-fix different skb headrooms

    commit 64289c8 upstream.
    
    The patch: "gro: fix different skb headrooms" in its part:
    "2) allocate a minimal skb for head of frag_list" is buggy. The copied
    skb has p->data set at the ip header at the moment, and skb_gro_offset
    is the length of ip + tcp headers. So, after the change the length of
    mac header is skipped. Later skb_set_mac_header() sets it into the
    NET_SKB_PAD area (if it's long enough) and ip header is misaligned at
    NET_SKB_PAD + NET_IP_ALIGN offset. There is no reason to assume the
    original skb was wrongly allocated, so let's copy it as it was.
    
    bugzilla : https://bugzilla.kernel.org/show_bug.cgi?id=16626
    fixes commit: 3d3be43
    
    Reported-by: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg>
    Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
    CC: Eric Dumazet <eric.dumazet@gmail.com>
    Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
    Tested-by: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Cc: Ben Hutchings <bhutchings@solarflare.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jarek Poplawski committed with gregkh Sep 4, 2010
  19. @gregkh

    gro: fix different skb headrooms

    commit 3d3be43 upstream.
    
    Packets entering GRO might have different headrooms, even for a given
    flow (because of implementation details in drivers, like copybreak).
    We cant force drivers to deliver packets with a fixed headroom.
    
    1) fix skb_segment()
    
    skb_segment() makes the false assumption headrooms of fragments are same
    than the head. When CHECKSUM_PARTIAL is used, this can give csum_start
    errors, and crash later in skb_copy_and_csum_dev()
    
    2) allocate a minimal skb for head of frag_list
    
    skb_gro_receive() uses netdev_alloc_skb(headroom + skb_gro_offset(p)) to
    allocate a fresh skb. This adds NET_SKB_PAD to a padding already
    provided by netdevice, depending on various things, like copybreak.
    
    Use alloc_skb() to allocate an exact padding, to reduce cache line
    needs:
    NET_SKB_PAD + NET_IP_ALIGN
    
    bugzilla : https://bugzilla.kernel.org/show_bug.cgi?id=16626
    
    Many thanks to Plamen Petrov, testing many debugging patches !
    With help of Jarek Poplawski.
    
    Reported-by: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg>
    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    CC: Jarek Poplawski <jarkao2@gmail.com>
    Cc: Ben Hutchings <bhutchings@solarflare.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Eric Dumazet committed with gregkh Sep 1, 2010
  20. @gregkh

    net: Fix a memmove bug in dev_gro_receive()

    commit e5093ae upstream.
    
    >Xin Xiaohui wrote:
    > I looked into the code dev_gro_receive(), found the code here:
    > if the frags[0] is pulled to 0, then the page will be released,
    > and memmove() frags left.
    > Is that right? I'm not sure if memmove do right or not, but
    > frags[0].size is never set after memove at least. what I think
    > a simple way is not to do anything if we found frags[0].size == 0.
    > The patch is as followed.
    ...
    
    This version of the patch fixes the bug directly in memmove.
    
    Reported-by: "Xin, Xiaohui" <xiaohui.xin@intel.com>
    Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Cc: Ben Hutchings <bhutchings@solarflare.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jarek Poplawski committed with gregkh Aug 11, 2010
  21. @paulfertser @gregkh

    plat-mxc: iomux-v3.h: implicitly enable pull-up/down when that's desired

    commit 6571534 upstream.
    
    To configure pads during the initialisation a set of special constants
    is used, e.g.
    #define MX25_PAD_FEC_MDIO__FEC_MDIO IOMUX_PAD(0x3c4, 0x1cc, 0x10, 0, 0, PAD_CTL_HYS | PAD_CTL_PUS_22K_UP)
    
    The problem is that no pull-up/down is getting activated unless both
    PAD_CTL_PUE (pull-up enable) and PAD_CTL_PKE (pull/keeper module
    enable) set. This is clearly stated in the i.MX25 datasheet and is
    confirmed by the measurements on hardware. This leads to some rather
    hard to understand bugs such as misdetecting an absent ethernet PHY (a
    real bug i had), unstable data transfer etc. This might affect mx25,
    mx35, mx50, mx51 and mx53 SoCs.
    
    It's reasonable to expect that if the pullup value is specified, the
    intention was to have it actually active, so we implicitly add the
    needed bits.
    
    Signed-off-by: Paul Fertser <fercerpav@gmail.com>
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    paulfertser committed with gregkh Oct 10, 2011
  22. @gregkh

    tuner_xc2028: Allow selection of the frequency adjustment code for XC…

    …3028
    
    commit 9bed77e upstream.
    
    This device is not using the proper demod IF. Instead of using the
    IF macro, it is specifying a IF frequency. This doesn't work, as xc3028
    needs to load an specific SCODE for the tuner. In this case, there's
    no IF table for 5 MHz.
    
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Mauro Carvalho Chehab committed with gregkh Jul 28, 2011
  23. @ming1 @gregkh

    uvcvideo: Set alternate setting 0 on resume if the bus has been reset

    commit d59a7b1 upstream.
    
    If the bus has been reset on resume, set the alternate setting to 0.
    This should be the default value, but some devices crash or otherwise
    misbehave if they don't receive a SET_INTERFACE request before any other
    video control request.
    
    Microdia's 0c45:6437 camera has been found to require this change or it
    will stop sending video data after resume.
    
    uvc_video.c]
    
    Signed-off-by: Ming Lei <ming.lei@canonical.com>
    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ming1 committed with gregkh Jul 16, 2011
  24. @jdelvare @gregkh

    carminefb: Fix module parameters permissions

    commit c84c142 upstream.
    
    The third parameter of module_param is supposed to be an octal value.
    The missing leading "0" causes the following:
    
    $ ls -l /sys/module/carminefb/parameters/
    total 0
    -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_displays
    -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_mode
    -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_mode_str
    
    After fixing the perm parameter, we get the expected:
    
    $ ls -l /sys/module/carminefb/parameters/
    total 0
    -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_displays
    -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_mode
    -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_mode_str
    
    Signed-off-by: Jean Delvare <jdelvare@suse.de>
    Cc: Paul Mundt <lethal@linux-sh.org>
    Cc: Sebastian Siewior <bigeasy@linutronix.de>
    Signed-off-by: Paul Mundt <lethal@linux-sh.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    jdelvare committed with gregkh Jul 8, 2011
  25. @gregkh

    iommu/amd: Fix wrong shift direction

    commit fcd0861 upstream.
    
    The shift direction was wrong because the function takes a
    page number and i is the address is the loop.
    
    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Joerg Roedel committed with gregkh Oct 11, 2011
  26. @sebott @gregkh

    ccwgroup: move attributes to attribute group

    commit dbdf1af upstream.
    
    Put sysfs attributes of ccwgroup devices in an attribute group to
    ensure that these attributes are actually present when userspace
    is notified via uevents.
    
    Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    sebott committed with gregkh Oct 30, 2011
  27. @gregkh

    KVM: s390: check cpu_id prior to using it

    commit 4d47555 upstream.
    
    We use the cpu id provided by userspace as array index here. Thus we
    clearly need to check it first. Ooops.
    
    Signed-off-by: Carsten Otte <cotte@de.ibm.com>
    Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Carsten Otte committed with gregkh Oct 18, 2011
  28. @AxelLin @gregkh

    ASoC: ak4535: fixup cache register table

    commit 7c04241 upstream.
    
    ak4535_reg should be 8bit, but cache table is defined as 16bit.
    
    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    AxelLin committed with gregkh Oct 13, 2011
  29. @morimoto @gregkh

    ASoC: ak4642: fixup cache register table

    commit 19b115e upstream.
    
    ak4642 register was 8bit, but cache table was defined as 16bit.
    ak4642 doesn't work correctry without this patch.
    
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    morimoto committed with gregkh Oct 13, 2011
  30. @gregkh

    nfsd4: ignore WANT bits in open downgrade

    commit c30e92d upstream.
    
    We don't use WANT bits yet--and sending them can probably trigger a
    BUG() further down.
    
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    J. Bruce Fields committed with gregkh Oct 10, 2011
  31. @gregkh

    nfsd4: fix seqid_mutating_error

    commit 5761630 upstream.
    
    The set of errors here does *not* agree with the set of errors specified
    in the rfc!
    
    While we're there, turn this macros into a function, for the usual
    reasons, and move it to the one place where it's actually used.
    
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    J. Bruce Fields committed with gregkh Aug 10, 2011
  32. @gregkh

    nfsd4: Remove check for a 32-bit cookie in nfsd4_readdir()

    commit 832023b upstream.
    
    Fan Yong <yong.fan@whamcloud.com> noticed setting
    FMODE_32bithash wouldn't work with nfsd v4, as
    nfsd4_readdir() checks for 32 bit cookies. However, according to RFC 3530
    cookies have a 64 bit type and cookies are also defined as u64 in
    'struct nfsd4_readdir'. So remove the test for >32-bit values.
    
    Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Bernd Schubert committed with gregkh Aug 8, 2011
  33. @gregkh

    tracing: Fix returning of duplicate data after EOF in trace_pipe_raw

    commit 436fc28 upstream.
    
    The trace_pipe_raw handler holds a cached page from the time the file
    is opened to the time it is closed. The cached page is used to handle
    the case of the user space buffer being smaller than what was read from
    the ring buffer. The left over buffer is held in the cache so that the
    next read will continue where the data left off.
    
    After EOF is returned (no more data in the buffer), the index of
    the cached page is set to zero. If a user app reads the page again
    after EOF, the check in the buffer will see that the cached page
    is less than page size and will return the cached page again. This
    will cause reading the trace_pipe_raw again after EOF to return
    duplicate data, making the output look like the time went backwards
    but instead data is just repeated.
    
    The fix is to not reset the index right after all data is read
    from the cache, but to reset it after all data is read and more
    data exists in the ring buffer.
    
    Reported-by: Jeremy Eder <jeder@redhat.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Steven Rostedt committed with gregkh Oct 14, 2011
  34. @gregkh

    time: Change jiffies_to_clock_t() argument type to unsigned long

    commit cbbc719 upstream.
    
    The parameter's origin type is long. On an i386 architecture, it can
    easily be larger than 0x80000000, causing this function to convert it
    to a sign-extended u64 type.
    
    Change the type to unsigned long so we get the correct result.
    
    Signed-off-by: hank <pyu@redhat.com>
    Cc: John Stultz <john.stultz@linaro.org>
    [ build fix ]
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    hank committed with gregkh Sep 20, 2011
  35. @gregkh

    kmod: prevent kmod_loop_msg overflow in __request_module()

    commit 37252db upstream.
    
    Due to post-increment in condition of kmod_loop_msg in __request_module(),
    the system log can be spammed by much more than 5 instances of the 'runaway
    loop' message if the number of events triggering it makes the kmod_loop_msg
    to overflow.
    
    Fix that by making sure we never increment it past the threshold.
    
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Jiri Kosina committed with gregkh Oct 26, 2011
Something went wrong with that request. Please try again.