Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndicated Links Displaying to the Far Left #10

Closed
mrkrndvs opened this Issue Dec 17, 2017 · 29 comments

Comments

Projects
None yet
3 participants
@mrkrndvs
Copy link

mrkrndvs commented Dec 17, 2017

I really like ZenPress, but have been wondering about the inclusion of Syndicated Links. They are presented in the far left. Is this intentional? Is it something in the Syndication Links Plugin?

screenshot 2017-12-17 at 9 58 52 pm

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 17, 2017

It is a theme problem, thanks for reporting, I will have a look!

@dshanske

This comment has been minimized.

Copy link

dshanske commented Dec 17, 2017

Would you consider integrating support? You can unhook the content filter and call the display directly

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 17, 2017

sure, but both should work

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Dec 19, 2017

@pfefferle the strange formatting also occurs when you search for something

zenpress search

Assume that this is probably different, but I thought that I would add it here, just in case it is related.

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 19, 2017

Do you use the latest master version?

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Dec 19, 2017

My previous version had been installed November 17. Just uploaded the latest Master. Both errors still there.

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 19, 2017

Hmm, I will have a Look, I can’t reproduce it at my blog.

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 19, 2017

Can you post the URL of the blog here?

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Dec 19, 2017

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 19, 2017

do you use any plugins that hooks into the post content? there is no <p> element around the paragraphs... that's why it shows up full size.

@pfefferle pfefferle referenced this issue Dec 19, 2017

Closed

add container #71

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Dec 19, 2017

Syndication Links Plugin is using a span element, so it can't be centered... I filed an issue there.

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Dec 19, 2017

Thank you

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 12, 2018

@mrkrndvs I committed a native implementation of Syndication Links, I am curious about your thoughts.

bildschirmfoto 2018-02-12 um 22 03 33

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 12, 2018

Ah, I saw you switched the theme... never mind ;)

@pfefferle pfefferle closed this Feb 12, 2018

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 13, 2018

Looks good @pfefferle. I notice that the search still has a SPAN issue?

screenshot 2018-02-13 at 10 51 41 pm

Also, I have collected some thoughts here.

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 13, 2018

@mrkrndvs do you use Gutenberg?

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 13, 2018

I tried to optimize the plugin with Gutenberg, so that you will be able to use content that is wider than the normal content, like here: https://notiz.blog/2017/12/07/zwoelf/ or here: https://notiz.blog/2017/10/04/readability/

But that means, that you always have to have an element surrounding the text inside the content-<div>... This shouldn't be a problem, because at least there should be a <p> element, but sometimes, plugins add text directly to the div, so it causes this issue.

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 13, 2018

I just saw that you have build your own child-theme and that you simply include the style.css, but this is not enough, I splitted the view-port dependent stuff into several stylesheets. You have to include 5 styles in total: https://github.com/pfefferle/ZenPress/blob/master/functions.php#L232

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 13, 2018

What forced me to change was the headless notes rss. This would not be an issue with my main site which is just for 'Articles'.

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 13, 2018

When I get a chance I will also turn off the plugins one by one and try and identify what is causing the issue with the search screen.

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 13, 2018

what was the problem with the "headless notes rss"?

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 13, 2018

Micro.blog requires 'no titles':

Part of indie microblogging is getting back to the simplicity of title-less posts. When you’re writing a microblog post in WordPress, just leave the title blank, and if necessary update the post template to not include the title in HTML or the RSS feed.(source)

For some reason it the posts were producing a "No Title" Title, so I tried David's 2016 (which I know does not have headings for notes) and it did worked.

Not sure if that makes sense.

pfefferle added a commit that referenced this issue Feb 13, 2018

added support for empty titles
for a better compatibility with micto.blog.

thanks @mrkrndvs for the hint

see the discussion here #10
@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 13, 2018

thanks for the hint @mrkrndvs, the latest commit should fix that problem.

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 13, 2018

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 20, 2018

@pfefferle I have had a second go at getting a child theme developed by @chrisaldrich working again with no success. I added all the stylesheets, but there is still aspects of the parent theme that are not coming through.

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Feb 20, 2018

Do I need to add Gutenberg for it to work?

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 20, 2018

No, you do not need Gutenberg... I think I have to release a "Client-Theme skeleton" to test it by myself...

@pfefferle

This comment has been minimized.

Copy link
Owner

pfefferle commented Feb 20, 2018

Thanks for the feedback!

@mrkrndvs

This comment has been minimized.

Copy link
Author

mrkrndvs commented Mar 11, 2019

Updated the theme for Read Write Respond from ZenPress to Autonomie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.