New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absence of `mbstring` php extensions causes webmentions to fail #122

Open
miklb opened this Issue Nov 11, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@miklb

miklb commented Nov 11, 2017

As reported in indieweb-wordpress the inclusion of the mb_convert_encoding can cause a fatal error if the mbstring php extension is not active or installed.

Report said that webmentions were not received with semantic linkbacks active, deactivating it allowed them to be received, thus why I opened it in the issue in this plugin.

When I looked for other examples of that function in core WordPress it seems if ( function_exists('mb_convert_encoding') ) is used.

@dshanske said it is a result of the php mf2 library so not sure if we need to do a PR upstream to wrap those in an if statement or do something on plugin side.

Just wanted to document so we don't forget to address.

@dshanske

This comment has been minimized.

Show comment
Hide comment
@dshanske

dshanske Nov 11, 2017

The thing is, the file in question is the PHP-MF2 Parser. So, should this be upstream?

dshanske commented Nov 11, 2017

The thing is, the file in question is the PHP-MF2 Parser. So, should this be upstream?

@dshanske

This comment has been minimized.

Show comment
Hide comment
@dshanske

dshanske Dec 25, 2017

At the least, let's consider raising a flag if this happens.

dshanske commented Dec 25, 2017

At the least, let's consider raising a flag if this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment