Pat Ferate pferate

  • Washington
  • Joined on
pferate commented on pull request google/google-api-python-client#64
Pat Ferate

@nathanielmanistaatgoogle: Alright, I've made the last few changes, how does it look now?

Pat Ferate
Pat Ferate

Alright. Just don't be surprised when the 2 tests fail in 2.6 on travis.

Pat Ferate

I think I just fixed the problem in the wrong part. I'll remove this and fix it @ line 204 in discovery.py similar to bdc4d8b.

pferate commented on pull request google/google-api-python-client#64
Pat Ferate

Alright... I think I got it all. I broke the history for a bit, but I think I got everything back in it's place. At least I was spelling it "consis…

Pat Ferate
Pat Ferate
Pat Ferate
Pat Ferate
pferate commented on pull request google/google-api-python-client#64
Pat Ferate

I've learned a lot about rewriting history these past few days. :) fbae355 has been incorporated to previous commits. (It was interesting splitting…

Pat Ferate
  • Pat Ferate fde7488
    Using unittest2 in place of unittest for Python 2.6 compatibility in …
Pat Ferate

@cnelson I would recommend trying my python3-module_updates branch (the branch in #64). There should be no difference with my python3 branch operat…

pferate commented on pull request google/google-api-python-client#64
Pat Ferate

So it looks like @unittest.skip() and @unittest.skipif() were added in 2.7, so the 2 tests fail as is in 2.6 (see the travis logs). It looks like w…

Pat Ferate
  • Pat Ferate fbae355
    Removing erroneous execute bit.
pferate commented on pull request google/google-api-python-client#64
Pat Ferate

It looks like there is another issue that needs to be addressed. I think when I was developing on my Windows computer last night, the permissions g…

pferate commented on pull request google/google-api-python-client#64
Pat Ferate

Alright.... I think we're good now. I've taken out the extra commits and cut it down to 11 commits. I had some fun with the rebasing, but I think I…

Pat Ferate
Pat Ferate
Pat Ferate
pferate commented on pull request google/google-api-python-client#64
Pat Ferate

Ok, thanks! I'm going through and cleaning up the commits now. Some of those commits that undo previous commits we put in after the initial PR was …

Pat Ferate
Pat Ferate

... and done.

Pat Ferate

Done...

Pat Ferate

I figured that an iterator wasn't needed since the dict was fairly small. I changed it to six.iteritems.

Pat Ferate

This PR is in response to your previous comment. (2) Some number of pull requests containing changes to the project configuration - .travis.yml and…

Pat Ferate

In a way, this does have to do with python3. Python2 will work with mixed tabs and spaces, but if you try to run it in Python3, it will fail immedi…

pferate commented on pull request google/google-api-python-client#64
Pat Ferate

I think I found what I was looking for. I overlooked it because I thought it was more in depth. https://code.google.com/p/google-api-python-client/…

pferate commented on pull request google/google-api-python-client#64
Pat Ferate

I tried looking for this in Google's style guide, but have been unable to find it anymore. I remember reading it before, and I recall, in general F…

pferate commented on pull request google/google-api-python-client#63
Pat Ferate

@nathanielmanistaatgoogle: I created my other branch (PR #64) off of this one, so it also includes these two commits. I suppose it's up to you how …