Skip to content
This repository has been archived by the owner on May 28, 2020. It is now read-only.

Moose enum fixes #33

Closed
wants to merge 1 commit into from
Closed

Moose enum fixes #33

wants to merge 1 commit into from

Conversation

tomhukins
Copy link

Moose 2.1100 deprecates the non-arrayref form of enum.

Moose 2.1100 deprecates the non-arrayref form of enum.
@bluefeet
Copy link

This one just bit me.
I've sent an email to the authors to see if we can get some action taken on this issue.

@perlDreamer
Copy link

This is affecting me as well. I would love to see this fixed RSN.

@pnu
Copy link

pnu commented Mar 22, 2014

+1 for merge and CPAN release.
@bluefeet did you get any response?
Looking at the other forks, @rustyconover seems to be active.
Current pause authors: @acme and @pfig

@rustyconover
Copy link
Collaborator

I haven’t gotten any response from @pfig.
Rusty

-- 
Rusty Conover
Lucky Dinosaur, LLC.

On March 22, 2014 at 8:00:35 AM, Panu Ervamaa (notifications@github.com) wrote:

+1 for merge and CPAN release.
@bluefeet did you get any response?
Looking at the other forks, @rustyconover seems to be active.
Current pause authors: @acme and @pfig


Reply to this email directly or view it on GitHub.

pnu added a commit to pnu/net-amazon-s3 that referenced this pull request Mar 23, 2014
pnu added a commit to pnu/net-amazon-s3 that referenced this pull request Mar 24, 2014
@jeteve
Copy link

jeteve commented Apr 10, 2014

This is affecting me too. Can't wait for the merge..

@tomhukins
Copy link
Author

All,

I don't use this module directly myself: I submitted the patch because it's a dependency of something I'm working with.

I encourage one or more of you to work through the adoption process described at Adopt a CPAN module, perhaps using the CPAN adoption request template if the current maintainer doesn't reply to you.

All the best,
Tom

@rustyconover
Copy link
Collaborator

I will send this to Pedro now.

Rusty

@perlDreamer
Copy link

Any updates on this?

@pfig
Copy link
Owner

pfig commented Apr 22, 2014

Hi guys,

I've been plagued by rl, but am now in a position where I can start giving this module the love it needs. Expect a release this week, incorporating a fix for this.

I apologise for the time it took me to reply.

@bluefeet
Copy link

/me happy dances.

On Mon, Apr 21, 2014 at 9:56 PM, Pedro Figueiredo
notifications@github.comwrote:

Hi guys,

I've been plagued by rl, but am now in a position where I can start giving
this module the love it needs. Expect a release this week, incorporating a
fix for this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-41003943
.

@jeteve
Copy link

jeteve commented Apr 28, 2014

Any update on that?

pfig pushed a commit that referenced this pull request May 6, 2014
@pfig
Copy link
Owner

pfig commented May 6, 2014

Merged, new release going out asap.

@jeteve
Copy link

jeteve commented May 6, 2014

Party!

@pfig
Copy link
Owner

pfig commented May 6, 2014

Thanks to everyone for your patience, and special thanks for those of you who provided patches.

@perlDreamer
Copy link

Did CPAN accept your release? I haven't seen a version newer than 0.59.

@rustyconover
Copy link
Collaborator

Pedro never replied to my co-maint request.

Rusty

-- 
Rusty Conover
Lucky Dinosaur, LLC.

On May 10, 2014 at 7:24:57 PM, Colin Kuskie (notifications@github.com) wrote:

Did CPAN accept your release? I haven't seen a version newer than 0.59.


Reply to this email directly or view it on GitHub.

@pfig
Copy link
Owner

pfig commented May 11, 2014

Just hit CPAN.

@rustyconover Let me get back yo you :)

@perlDreamer
Copy link

There is one line that is still not following the new required enum syntax. I'll work up a pull request tonight or tomorrow.

@bluefeet
Copy link

Any work on this? I'm back to upgrading Moose (I stalled it the first time
this issues came up) @work and still getting some enum issues.

On Mon, May 19, 2014 at 2:58 PM, Colin Kuskie notifications@github.com
wrote:

There is one line that is still not following the new required enum
syntax. I'll work up a pull request tonight or tomorrow.


Reply to this email directly or view it on GitHub
#33 (comment).

@revmischa
Copy link

Passing a list of values to enum is deprecated. Enum values should be wrapped in an arrayref. at local/lib/perl5/x86_64-linux-thread-multi/Moose/Util/TypeConstraints.pm line 440.
Moose::Util::TypeConstraints::enum('StorageClass', 'standard', 'reduced_redundancy') called at local/lib/perl5/Net/Amazon/S3/Client/Object.pm line 21

@sysdef
Copy link

sysdef commented Sep 22, 2014

Still having the same issue here even after the last fix:

Passing a list of values to enum is deprecated. Enum values should be wrapped in an arrayref. at C:/myperl/perl/vendor/lib/Moose/Util/TypeConstraints.pm
line 440.
Moose::Util::TypeConstraints::enum("StorageClass", "standard", "reduced_redundancy") called at C:/myperl/perl/site/lib/Net/Amazon/S3/Client/Object.pm line 21=

veryrusty pushed a commit to logicly-au/net-amazon-s3 that referenced this pull request Nov 7, 2019
veryrusty pushed a commit to logicly-au/net-amazon-s3 that referenced this pull request Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
9 participants