Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support reduced-redundancy storage and user metadata #6

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
3 participants

arc commented May 19, 2012

Hi. This pull request makes the following changes to Net::Amazon::S3::Client::Object:

  • Document the content-disposition support
  • Extend the content-disposition support to put_filename as well as put (seems to be an oversight in the original implementation)
  • Refactor put and put_filename to prevent that sort of inconsistency in the future
  • Add a storage_class attribute, to allow selection of reduced-redundancy storage when uploading an object
  • Add a user_metadata attribute, to allow setting user metadata when uploading an object; in addition, when downloading an object that has user metadata, the metadata is stored in the attribute, so callers can find it

Please let me know if there are any changes you'd want to see before accepting this.

Thanks.

arc commented May 29, 2012

Hi, Pedro. I’ve just added another commit, which adds a get_decoded method — like get, but it decodes any Content-Encoding (using decoded_content from HTTP::Response).

I’m currently using these changes in a production system, so I'd be very happy to get them folded in upstream. Is there anything I can do to help that happen?

Thanks.

Owner

pfig commented Mar 16, 2013

Hi Aaron,

first of all, apologies for the delay :(

I'm starting work on this one now.

Thank you so much for the patch, and for your patience.

pnu added a commit to pnu/net-amazon-s3 that referenced this pull request Mar 23, 2014

pnu added a commit to pnu/net-amazon-s3 that referenced this pull request Mar 24, 2014

Owner

pfig commented May 5, 2014

Merged, will go out briefly. Thank you very much for this, and for putting up with the delay.

@pfig pfig closed this May 5, 2014

jhannah commented May 5, 2014

-blink- merged 2 hours ago? Merged into where? Is github lying to me? :) @pfig do you and/or Léon want more github and/or PAUSE Collabs?

Owner

pfig commented May 6, 2014

I hadn't pushed when I closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment