Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Telegraf on ARM #627

Closed
wants to merge 2 commits into from
Closed

Conversation

robbiet480
Copy link

Telegraf is now building on ARM! This PR incorporates upstream changes at freebsd/freebsd-ports@8a143a3 to enable building telegraf on ARM as well as enabling the package to be installed on ARM.

More info: influxdata/telegraf#5282

@victorhooi
Copy link

This would be awesome!

I have several SG-3100's, and would be amazing to have this available there as well.

Are there any blockers to having this go through?

@rbgarga
Copy link
Member

rbgarga commented Apr 11, 2019

net-mgmt/telegraf is on version 1.10.1 on pfSense 2.5.0 snapshots. I've enabled the build of pfSense-pkg-Telegraf for armv7 on this version as well so we can evaluate if it works as expected before think about backport it to 2.4.4. The patch in this PR is outdated so I'm closing it.

Thanks!

@rbgarga rbgarga closed this Apr 11, 2019
@rbgarga
Copy link
Member

rbgarga commented Apr 11, 2019

FYI, lang/go is not building on poudriere armv7 jail. I'll re-enable Telegraf on arm when it's fixed upstream.

@robbiet480
Copy link
Author

Thanks for the update @rbgarga

@victorhooi
Copy link

@rbgarga Bugger about lang/go not building - do you have a link to the upstream bug?

@victorhooi
Copy link

I think this is working now?

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221297

Was marked as fixed now. Does this mean we can pull in Telegraf now? =)

@rbgarga
Copy link
Member

rbgarga commented Apr 24, 2019

I think this is working now?

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221297

Was marked as fixed now. Does this mean we can pull in Telegraf now? =)

Not that simple. lang/go cannot build using qemu-user-static, which is the method we currently use. We need native builders and restructure our build process to be able to use it.

@artooro
Copy link

artooro commented May 27, 2019

@rbgarga would you guys consider a custom port of telegraf for pfSense that pulls in pre-compiled binaries so that telegraf can be compiled outside of poudriere and then pulled into a freebsd package?

I do this currently for an internal freebsd package we use, it's not ideal but it works, and the only workaround I'm currently aware of.

Essentially it would be a two step build. First run the native go cross compile to create binaries, and then run the poudriere jobs.

@onedr0p
Copy link

onedr0p commented Jul 4, 2019

If I have it correct we're just waiting on pfSense to update to 2.5.x to have telegraf supported on ARM?

@victorhooi
Copy link

victorhooi commented Jul 5, 2019 via email

@onedr0p
Copy link

onedr0p commented Jul 5, 2019

See this comment #627 (comment)

@victorhooi
Copy link

Hmm - but I thought in the comment directly below that, he’s saying it’s not working again?

#627 (comment)

FYI, lang/go is not building on poudriere armv7 jail. I'll re-enable Telegraf on arm when it's fixed upstream.

netgate-git-updates pushed a commit that referenced this pull request Sep 27, 2022
Release 2.4.9 Tue September 20 2022
        Security fixes:
       #629 #640  CVE-2022-40674 -- Heap use-after-free vulnerability in
                    function doContent. Expected impact is denial of service
                    or potentially arbitrary code execution.

        Bug fixes:
            #634  MinGW: Fix mis-compilation for -D__USE_MINGW_ANSI_STDIO=0
            #614  docs: Fix documentation on effect of switch XML_DTD on
                    symbol visibility in doc/reference.html

        Other changes:
            #638  MinGW: Make fix-xmltest-log.sh drop more Wine bug output
       #596 #625  Autotools: Sync CMake templates with CMake 3.22
            #608  CMake: Migrate from use of CMAKE_*_POSTFIX to
                    dedicated variables EXPAT_*_POSTFIX to stop affecting
                    other projects
       #597 #599  Windows|CMake: Add missing -DXML_STATIC to test runners
                    and fuzzers
       #512 #621  Windows|CMake: Render .def file from a template to fix
                    linking with -DEXPAT_DTD=OFF and/or -DEXPAT_ATTR_INFO=ON
       #611 #621  MinGW|CMake: Apply MSVC .def file when linking
       #622 #624  MinGW|CMake: Sync library name with GNU Autotools,
                    i.e. produce libexpat-1.dll rather than libexpat.dll
                    by default.  Filename libexpat.dll.a is unaffected.
            #632  MinGW|CMake: Set missing variable CMAKE_RC_COMPILER in
                    toolchain file "cmake/mingw-toolchain.cmake" to avoid
                    error "windres: Command not found" on e.g. Ubuntu 20.04
       #597 #627  CMake: Unify inconsistent use of set() and option() in
                    context of public build time options to take need for
                    set(.. FORCE) in projects using Expat by means of
                    add_subdirectory(..) off Expat's users' shoulders
       #626 #641  Stop exporting API symbols when building a static library
            #644  Resolve use of deprecated "fgrep" by "grep -F"
            #620  CMake: Make documentation on variables a bit more consistent
            #636  CMake: Drop leading whitespace from a #cmakedefine line in
                    file expat_config.h.cmake
            #594  xmlwf: Fix harmless variable mix-up in function nsattcmp
  #592 #593 #610  Address Cppcheck warnings
            #643  Address Clang 15 compiler warnings
       #642 #644  Version info bumped from 9:8:8 to 9:9:8;
                    see https://verbump.de/ for what these numbers do

        Infrastructure:
       #597 #598  CI: Windows: Start covering MSVC 2022
            #619  CI: macOS: Migrate off deprecated macOS 10.15
            #632  CI: Linux: Make migration off deprecated Ubuntu 18.04 work
            #643  CI: Upgrade Clang from 14 to 15
            #637  apply-clang-format.sh: Add support for BSD find
            #633  coverage.sh: Exclude MinGW headers
            #635  coverage.sh: Fix name collision for -funsigned-char

        Special thanks to:
            David Faure
            Felix Wilhelm
            Frank Bergmann
            Rhodri James
            Rosen Penev
            Thijs Schreijer
            Vincent Torri
                 and
            Google Project Zero

Exp-run by:	antoine
PR:		266524
netgate-git-updates pushed a commit that referenced this pull request Jan 8, 2024
- Changed handling of locale to accept "C"

Dec 2023 - 2.3.3
- WIP: Started to reduce the possibility of SQLi with the use of prepared statements.
- Bugfix: Sat QSO edit was not showing the worked SAT (Closes #645)
- Bugfix: After editing a QSO, the restore was not working properly. (Closes #649)
- Bugfix: In Sat QSO, still not selected band may make the QSO unusable. (Closes #651)
- Bugfix: All Gridsquares are now listed when Export to ADIF is used. (Closes #514)
- Bugfix: Selecting a sat with a new band made the bandcombobox unusable. #613
- Bugfix: F1 (online manual link fixed (Closes #627) (TNX ikbenkous)
- Bugfix: 'Usage' does not properly handle arguments, print newlines or return status codes (Closes #625) (TNX ikbenkous)

- Enhancement: Improved the Frequency entry. (Closes #622) (TNX ikbenkous)
- Enhancement: Use a good discriminator in header guards (Closes #624) (TNX ikbenkous)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants