Add HoneyTrap pfSense port #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2020 10:24
Removed the binary from the pfSense port since it's included in the FreeBSD-port.
rbgarga
requested changes
Feb 18, 2020
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap-plugin.xml
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/www/honeytrap/honeytrap_logs.php
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/www/honeytrap/honeytrap_settings.php
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/www/honeytrap/honeytrap_settings.php
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/www/honeytrap/honeytrap_settings.php
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/www/shortcuts/pkg_honeytrap.inc
Outdated
Show resolved
Hide resolved
|
@Ezri-Mudde files are still indented using spaces instead of TABs |
Sorry, thought I fixed that. I hope everything is correct now. |
rbgarga
reviewed
Feb 24, 2020
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
rbgarga
requested changes
Feb 25, 2020
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
rbgarga
requested changes
Feb 25, 2020
security/pfSense-pkg-HoneyTrap/files/usr/local/pkg/honeytrap/honeytrap-plugin.inc
Outdated
Show resolved
Hide resolved
rbgarga
approved these changes
Feb 27, 2020
jim-p
requested changes
Feb 27, 2020
There was a problem hiding this comment.
Since this package adds its own log file, please review the logging changes in 2.5.0 and setup log rotation to ensure the log is properly managed. See https://redmine.pfsense.org/issues/9712 for details and links to examples.
|
I still have reservations about running this kind of service on a firewall and encouraging its use by making it available as a package. |
jim-p
requested changes
Aug 21, 2020
|
After internal discussion we decided to don't accept this contribution. This functionality doesn't belong to a firewall. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the HoneyTrap pfSense port. The port depends on security/honeytrap so it should be cherry-picked from FreeBSD.
Ticket #9989