Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix logic bug in preproc auto-rule-disable so it skips already disabled rules #412

Merged
merged 1 commit into from

2 participants

@bmeeks8

Change Log

Date: 03/22/2013

  1. Fix logic bug in function that auto-disables rules containing rule options associated with disabled pre-processors. The logic was supposed to skip disabling already disabled rules, but instead was skipping enabled rules.
@cbuechler cbuechler merged commit e9360d2 into pfsense:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 23, 2013
  1. @bmeeks8
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  config/snort/snort.inc
View
3  config/snort/snort.inc
@@ -1855,7 +1855,8 @@ function snort_filter_preproc_rules($snortcfg, &$active_rules) {
***************************************************/
foreach ($active_rules as $k1 => $rulem) {
foreach ($rulem as $k2 => $v) {
- if ($v['disabled'] == 0)
+ /* If rule is already disabled, skip it. */
+ if ($v['disabled'] == 1)
continue;
foreach ($rule_opts_preprocs as $opt => $preproc) {
$pcre = "/\s*\b" . $opt . "/i";
Something went wrong with that request. Please try again.