master
Name already in use
Commits on May 15, 2023
-
Fix ipsec_ikeid_next() copy/paste errors
The content of ipsec_ikeid_next() had some references to undefined variables stemming from a change of nomenclature between 'ike', 'req', and 'key'. This seems to stem from content in ipsec_ikeid_next() originating as a copy/paste from ipsec_new_reqid, and only some of the identifiers were changed. This commit corrects these errors by replacing 'keyid' and 'reqid' with 'ikeid'.
Reid Linnemann committedMay 15, 2023 -
Commits on May 12, 2023
-
Add VLAN support validation for the Packet Capture interface. Fix #14376
Marcos Mendoza committedMay 12, 2023
Commits on May 11, 2023
Commits on May 10, 2023
-
Disable CARP until services have started and before shutdown/reboot. F…
…ixes #2218 CARP has historically been enabled as part of interface bringup and sync setup fairly early in rc.bootup. This change intentionally shuts down CARP from interface bringup all the way until services have been started to ensure that a pfSense host does not take over virtual addresses prematurely. Additionally, CARP is now shut down during pfSense-rc.shutdown before shutting down services to allow a backup to take over the address before interrupting services. src/etc/inc/interfaces.inc: Do not enable CARP in interfaces_sync_setup() if the platform is still booting, as it will be done explicitly by rc.bootup Do not call interfaces_sync_setup() from interfaces_vips_configure() if the platform is still booting. This was causing CARP configuration to be done twice during rc.bootup src/etc/inc/pfsense-utils.inc Refactor net.inet.carp.allow twiddling into function enable_carp() src/etc/inc/system.inc Disable CARP in system_reboot_cleanup after captive portal accounting is stopped src/etc/pfSense-rc.shutdown Disable CARP before executing shutdown scripts in /usr/local/etc/rc.d src/etc/phpshellsessions/disablecarp src/etc/phpshellsessions/enablecarp Use enable_carp() function src/etc/rc.bootup Explicitly disable CARP prior to interface configuration, and re-enable if CARP VIPs exist after the marking the system as no longer booting src/usr/local/pfSense/include/www/firewall_virtual_ip.inc src/usr/local/www/status_carp.php Use enable_carp() function
Reid Linnemann committedMay 10, 2023 -
Relocate ConfigLibTest.php to new tests directory
To correctly handle running test in situ, add set_include_path() call to add relative src/etc/inc path to the include path string
Reid Linnemann committedMay 10, 2023
Commits on May 9, 2023
Commits on May 8, 2023
Commits on May 5, 2023
-
Revert "Correct RAM disk swap calculation. Issue #13508"
This reverts commit b10998b.
Commits on May 4, 2023
Commits on May 3, 2023
-
Correct RAM disk swap calculation. Issue #13508
It was not factored into the shell version as it should be (still a problem here, see Redmine). It was also returning a bogus small value on systems that have no swap configured.
-
Commits on May 2, 2023
-
-
-
-
Update method of finding rule labels. Fixes #14336
The way rule labels are returned from pfSense_get_pf_rules() changed, so this code needs to follow the new format.
Commits on May 1, 2023
-
FW rule GW status popup improvements. Fixes #14327
* Fix status check to account for current gw status/substatus strings * Include Tier for gateway groups * Sort groups by tier and then name * Fix interface name printout * Optimize interface name and gw address display to avoid multiple loops through gateway array.
Commits on Apr 27, 2023
-
Use new utility function for ethertype, use correct operator, and rem…
…ove redundant code. Fix #13382
Marcos Mendoza committedApr 27, 2023 -
Expose new utility function to validate ethertype. redmine #14308
Marcos Mendoza committedApr 27, 2023 -
Corrections for shaper wizards. Fixes #13915
* Fix many inconsistencies in formatting between the wizards * Fix a few potential bugs in both (changes made to one to fix issues were not reflected in the other). * Various style and whitespace corrections.
Commits on Apr 26, 2023
-
Load if_gif if needed when creating a gif interface. Fixes #14035
Reid Linnemann committedApr 26, 2023 -
PHP 8 fixes in Dedicated Links Shaper Wizard. Fixes #13915
While here, clean up some formatting.
-
PHP 8 fixes in Multi-All Shaper Wizard. Issue #13915
While here, clean up some formatting.
Commits on Apr 21, 2023
Commits on Apr 19, 2023
Commits on Apr 18, 2023
-
rc.carpmaster: remove openlog() call which changes php-fpm log facility
In commit 0eae38c, this call was added alongside other changes to the rc.carpmaster script intended to reconfigure captiveportals upon promotion to master. When php-fpm executes rc.carpmaster, this call changes php-fpm's log facility and logs from php-fpm and commands that it spawns are no longer directed correctly via syslogd from that point forward.
Reid Linnemann committedApr 18, 2023
Commits on Apr 17, 2023
-
Remove invalid syslog test. Fixes #14283
Having an empty syslog config section is valid, as is not having a section at all. We should always generate the configuration since we always start the syslog daemon. If we want to eventually allow not configuring or running the daemon at all, we should add a dedicated option for that, but as-is this test wasn't doing what it implied.