Commits on Oct 26, 2016
  1. Make sure we consume staging packages on build process after pfSense-…

    …repo became a package
    rbgarga committed Oct 26, 2016
Commits on Oct 25, 2016
  1. dyndns: add header processing in curl

    some dyndns implementations rely on the correct HTTP header being set. the information was lost and now fixed.
    filnko committed with rbgarga Oct 24, 2016
Commits on Oct 24, 2016
  1. Stop using -y on filterdns call

    rbgarga committed Oct 24, 2016
  2. Rework captive portal to run with stock IPFW (round 1)

    - Remove use of IPFW context
    - Create a rule that will skip to proper rule for each cp zone
    - Use new PHP module functions wherever is possible
    rbgarga committed Oct 24, 2016
  3. REmove accidental text

    sbeaver-netgate committed Oct 24, 2016
  4. Added hostname to login page.

    Option control required
    sbeaver-netgate committed Oct 24, 2016
  5. Update the variable with the round() return otherwise it does not has…

    … any effect.
    Found while testing Ticket #6272.
    loos-br committed Oct 24, 2016
  6. Fix #6872 CP bandwidth 0 is no valid

    The front-end validation prevents zero from being entered. "Leave empty" is the way to specify no limit.
    phil-davis committed on GitHub Oct 24, 2016
Commits on Oct 21, 2016
  1. Revert "Revert "Enable IPFW on PHP module""

    This reverts commit 9fdd0c7.
    rbgarga committed Oct 21, 2016
  2. Revert "Enable IPFW on PHP module"

    This reverts commit c04887d.
    rbgarga committed Oct 21, 2016
Commits on Oct 20, 2016
  1. Enable IPFW on PHP module

    rbgarga committed Oct 20, 2016
  2. Improve IPv4 address validation for services_dhcp

    The input pattern that goes with Form_IpAddress by default allows for IPv4 and IPv6 valid characters. The back-end validation here is checking for IPv4 addresses, so it seems reasonable that the front-end input pattern checks might as well be restricted to the IPv4 valid characters. Unneeded setPattern have also been removed.
    The exception is Gateway, where the special string "none" is allowed, so I just left the setPattern as it is (yes, it could be modified to only allow the letters "n" "o" and "e").
    phil-davis committed on GitHub Oct 20, 2016
  3. Fix display advanced after input error for system_gateways_edit

    Use case:
    1) Edit a gateway that has no advanced settings (i.e. the Advanced section does not need to open on page load) - that works fine.
    2) Modify the Gateway IP Address to something invalid like 1:2::z
    3) Press Save
    The error is shown - "A valid gateway IP address must be specified" - good.
    The Advanced section is shown - not good.
    The problem is that after POSTing the page, and the resulting validation, finding an input error, and re-displaying the page, each of the $pconfig keys is set, even though set to the empty string "". So the isset() tests are true, and it gets the wrong idea.
    We only care about these parameters if they are not "". In this case !empty() gives the correct result, because although a value of 0 will be considered empty, 0 is not allowed by the front-end of the UI anyway (as it happens, these parameters are not allowed to be 0), so we never get that case. And by the way, I generally hate empty() because of having to think of all its quirks.
    phil-davis committed on GitHub Oct 20, 2016
  4. Fix is_macaddr().

    Hexadecimal numbers without the '0' padding are also valid, e.g:
    loos-br committed Oct 20, 2016
Commits on Oct 19, 2016
Commits on Oct 18, 2016
  1. Fix #6828

    Until 2.3.x pfSense carried a patch that changed the behavior of 'route
    change' command, making it add the route when it fails to change.
    On 2.4 this patch was removed and will not be added back. This change
    adjust PHP code to deal with route add / change and make it work
    without the patch
    rbgarga committed Oct 18, 2016
Commits on Oct 15, 2016
  1. xmlrpc, use authentication through the basic auth header instead of e…

    …xtra user/pass parameters
    PiBa-NL committed Oct 15, 2016
Commits on Oct 14, 2016
  1. Make setup_serial_port() write config files safely

    This function used to replace /boot.conf, /boot/loader.conf and
    /etc/ttys on every call. Depending of the moment a power failure
    happens, any of these files can be blank and it'll break console setup
    on next boot.
    Usa safe_write_file() to save these 3 files to disk to make sure they
    are sync'd
    rbgarga committed Oct 14, 2016
  2. Prevent /etc/ttys to miss essential lines

    We do not create /etc/ttys from scratch but we change it on every boot.
    If original file is corrupted for some reason we can end up with a file
    missing essential lines. Added a check to verify if these lines are
    missing and add them back in this case
    rbgarga committed Oct 14, 2016
Commits on Oct 13, 2016
  1. Fix up help text on outbound NAT.

    jim-p committed Oct 13, 2016
  2. In the setup wizard, do not change the DHCP range if it is already se…

    …t inside the new subnet. Otherwise it will overwrite a range set manually from the DHCP settings or the console when the wizard is run later. Fixes #4820
    jim-p committed Oct 13, 2016
  3. Add extra validations on is_inrange_v[46]

    Verify if addresses are valid IP address before convert them to make
    numeric comparison.
    While here, adjust indent.
    Inspired by: @phil-davis patch at PR #3189
    rbgarga committed Oct 13, 2016