Skip to content
Permalink
Branch: master
Commits on Sep 28, 2018
Commits on Sep 27, 2018
  1. - tab to space

    luckman212 committed Sep 27, 2018
    - "IP" -> "IP address"
    - don't specify gw on route delete (not needed as per jim-p
    - helptext: remove '.' for consistency, and "nat" -> "NAT"
  2. gettext on strings

    luckman212 committed Sep 27, 2018
Commits on Sep 26, 2018
  1. garga changes

    luckman212 committed Sep 26, 2018
    move conditional before platform_booting
    and join w && instead of indenting
  2. Fix a display bug in status_gateways.php

    luckman212 committed Sep 26, 2018
    This bug causes the Monitor IP to appear even when a gateway
    is unmonitored. The monitor IP from the last gateway in the list
    to have one will simply get repeated. This patch fixes that bug,
    and also cleans up a few other things- unused variables, gets
    var names to match whats in system_gateways.php, changes nest of
    if...elseif to cleaner switch() etc.
Commits on Sep 25, 2018
  1. default to the lan interface on WOL page, unless another if is

    luckman212 committed Sep 25, 2018
    submitted in the form data.
Commits on Sep 20, 2018
Commits on Sep 18, 2018
  1. reduce the tons of log spew that currently spit out during boot

    luckman212 committed Sep 18, 2018
    and gateway failure events. Try to make the logs readable again,
    while still allowing verbose logging if needed via a new hidden
    config option:
    
    ['system']['gw-debug']
  2. small change to fixup https://redmine.pfsense.org/issues/8851

    luckman212 committed Sep 18, 2018
    without this, clicking edit on existing CA goes to wrong screen
    and breaks Save button
Commits on Sep 14, 2018
  1. Underscores never hurt nobody

    luckman212 committed Sep 14, 2018
    Also, i18n
Commits on Aug 3, 2018
  1. Removes some legacy code in auth.inc

    luckman212 committed Aug 3, 2018
    There was a compat issue between PHP's $2y$ bcrypt hashes and
    older versions of FreeBSD. However, this compat issue was fixed
    long ago and appeared in FreeBSD 11.0-RELEASE
    https://reviews.freebsd.org/D2742
Commits on Mar 3, 2018
Commits on Oct 10, 2017
Commits on Oct 6, 2017
Commits on Sep 25, 2017
  1. Tiny typo

    luckman212 committed Sep 25, 2017
    Just removed an extra `'.'`
Commits on Apr 4, 2017
Commits on Mar 30, 2017
Commits on Mar 29, 2017
  1. Adds ability to ignore DHCP offers from multiple servers

    luckman212 committed Mar 29, 2017
    - Forum thread: https://forum.pfsense.org/index.php?topic=124046.msg705100#msg705100
    - related dhclient source:
    https://github.com/pfsense/FreeBSD-src/blob/devel/sbin/dhclient/clparse.c#L945
    
    **changed files:**
    /usr/local/www/interfaces.php
    /etc/inc/interfaces.inc
Commits on Mar 10, 2017
  1. Adds option to skip adding IPv6 entries in /etc/hosts for LANs

    luckman212 committed Mar 10, 2017
    If a LAN interface's IPv6 configuration is set to Track, and the tracked interface loses connectivity, it can cause connections to the firewall that were established via IPv6 hostname to fail. This can happen unintentionally when accessing the system by hostname, since by default both IPv4 and IPv6 entries are added to /etc/hosts. This patch + enabling this option prevents those IPv6 records from being created and prevents this from occurring.
    
    Set the option in System > Advanced > Networking
    
    FILES CHANGED
    - /etc/inc/system.inc
    - /usr/local/www/system_advanced_network.php
Commits on Mar 7, 2017
  1. Test fix for hanging check_reload_status

    luckman212 committed Mar 7, 2017
    After killing php-fpm (console opt 16) check_reload_status would sometimes hang, consuming 100% of 1 cpu core. I found a reference https://redmine.pfsense.org/issues/3884#note-4 saying that check_reload_status depends on php-fpm. This patch wraps the restart of php-fpm with a stop/start of check_reload_status. In my limited testing, this has eliminated the hangs, which were pretty easily reproducible before.
Commits on Feb 9, 2017
  1. 5th try

    luckman212 committed Feb 9, 2017
    - change $do_ping default value to 'true' (which emulates the previous default behavior) to avoid any unexpected results
  2. 4th attempt!

    luckman212 committed Feb 9, 2017
    - Reworked based on recent comments from @rbgarga
Commits on Feb 8, 2017
  1. 3rd try!

    luckman212 committed Feb 8, 2017
    - incorporate suggestions from @rbgarga with slight modification
  2. 2nd try. . .

    luckman212 committed Feb 8, 2017
    /etc/inc/util.inc:
    - arp_get_mac_by_ip() updated to support IPv6
    - attempt at code streamline
    
    /usr/local/www/services_dhcp_edit.php:
    - streamline code, now just a simple call to arp_get_mac_by_ip()
Commits on Feb 6, 2017
  1. add Copy DUID convenience button

    luckman212 committed Feb 6, 2017
    - adds `Copy DUID` convenience button/js
    - no page refresh or AJAX
  2. enhancements to services_dhcp_edit.php

    luckman212 committed Feb 6, 2017
    - added ndp call to get MAC addr if remote client is connected via IPv6
    - automatically hide `Copy MAC` button if arp/ndp returns null
    - switch to exec() instead of backticks for calls to arp
    - uses builtin is_ipaddr() function from util.inc
Commits on Feb 4, 2017
Commits on Jul 16, 2016
  1. Fix "http://pf.sense/UNKNOWN" links in Pkg Manager

    luckman212 committed Jul 16, 2016
    I noticed recently that many packages do not have the 'www' field in the database filled, or have it set to UNKNOWN  The way the table is built, this causes bad links to be generated pointing to e.g. http://pf.sense/UNKNOWN.  This patch fixes it, causing only packages with actual links to get the <a> tag.
Commits on Apr 26, 2016
  1. Extra comma, not needed

    luckman212 authored and sbeaver-netgate committed Apr 25, 2016
    Removed an extra comma - more correct IMO
    (cherry picked from commit 90968c4)
Commits on Feb 29, 2016
  1. Fix unbound.inc so zero value for *_num_tcp is honored

    luckman212 authored and sbeaver-netgate committed Feb 27, 2016
    In the Unbound documentation, it is noted that setting "outgoing-num-tcp" to "0" disables TCP queries. In testing I noticed that although I could select & save a value of "0" in the Unbound Advanced Config, the actual value written to /var/unbound/unbound.conf was still the default "10". Apparently in PHP, a value of "0" still tests "false" for !empty(). Changing the test to isset() seems to fix the issue.
Commits on Feb 27, 2016
  1. Fix unbound.inc so zero value for *_num_tcp is honored

    luckman212 committed Feb 27, 2016
    In the Unbound documentation, it is noted that setting "outgoing-num-tcp" to "0" disables TCP queries. In testing I noticed that although I could select & save a value of "0" in the Unbound Advanced Config, the actual value written to /var/unbound/unbound.conf was still the default "10". Apparently in PHP, a value of "0" still tests "false" for !empty(). Changing the test to isset() seems to fix the issue.
You can’t perform that action at this time.