Unset logfilesize rather than let it be zero #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) When saving Status: System logs: Settings, if the Log File Size field is left blank, it gets cast to (int) and ends pu as zero "0" in config.xml. That breaks the creation of clog files in /etc/rc during boot. /etc/rc expects logfilesize to be unset, blank or a valid integer >= 5120. So, if the field is empty, then make sure that it is unset in config.xml 2) For data items that are cast to (int) whenputting into the config (nentries and logfilesize), copy the resulting value back to the $pconfig array. When the user enters 123.45 the in field, is correctly truncated to (int) 123 in config.xml. By copying that back to $pconfig, the "123" also appears correctly on the GUI page after the save. 3) Mention the units of measure of Log File Size (Bytes) 4) Mention that the user should press Save first when changing values, then they can use "Reset Log Files" to set the log file sizes to the just-saved value. 5) Display a message when the log files have been reset - it's a bit more user-friendly IMHO.
| @@ -113,7 +114,13 @@ function is_valid_syslog_server($target) { | |||
| if (!$input_errors) { | |||
| $config['syslog']['reverse'] = $_POST['reverse'] ? true : false; | |||
| $config['syslog']['nentries'] = (int)$_POST['nentries']; | |||
| $config['syslog']['logfilesize'] = (int)$_POST['logfilesize']; | |||
| $pconfig['nentries'] = $config['syslog']['nentries']; | |||
| if (isset($_POST['logfilesize']) && (strlen($_POST['logfilesize']) > 0)) { | |||
There was a problem hiding this comment.
You can use empty() here since it treats 0 as false as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, if the field is empty, then make sure that it is unset in config.xml