Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall_rules_edit stop Floating field displaying #3329

Merged
merged 1 commit into from Jan 4, 2017

Conversation

Projects
None yet
3 participants
@phil-davis
Copy link
Contributor

phil-davis commented Dec 31, 2016

Seems to fix https://redmine.pfsense.org/issues/7057
But I have not looked underneath the hood - just copied the way other hidden fields are done in that code.

firewall_rules_edit stop Floating field displaying
Seems to fix https://redmine.pfsense.org/issues/7057
But I have not looked underneath the hood - just copied the way other hidden fields are done in that code.

@rbgarga rbgarga requested a review from sbeaver-netgate Jan 2, 2017

@sbeaver-netgate
Copy link
Contributor

sbeaver-netgate left a comment

This is the correct way to add a hidden element that will never need to be "un-hidden"

@netgate-git-updates netgate-git-updates merged commit 76895c7 into pfsense:master Jan 4, 2017

@phil-davis phil-davis deleted the phil-davis:patch-1 branch Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.