Highlight online+active in results #948

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

stilez commented Feb 19, 2014

"class=grey" isn't really useful with a significant number of temporary leases, because you can't quickly pick out by eye, the few current or active leases from a long list of inactive or past leases.

This highlights the "online" and "active" leases that currently exist, so it's much easier to see the active or online devices in the leases table

@stilez stilez Highlight online+active in results
"class=grey" isn't really useful with a significant number of temporary leases, because you can't quickly pick out by eye, the few current or active leases from a long list of inactive or past leases.

This highlights the "online" and "active" leases that currently exist, so it's much easier to see the active or online devices in the leases table
f92b888

wagonza commented Feb 19, 2014

It would better to just add a class and adjust all.css instead of inline css.

Contributor

stilez commented Feb 19, 2014

Just add ".highlight_green" class or something to all.css? Do I need to do anything to other css files or themes?

wagonza commented Feb 21, 2014

yeah and ideally update all other themes as well. Might be better to choose a better name incase the other themes want to use a different colour.

Owner

rbgarga commented Apr 9, 2015

@stilez Do you have plans to make changes suggested by @wagonza? Otherwise this can be closed.

Contributor

stilez commented Apr 13, 2015

I'd like to, but not confident enough about how pfSense css formating is done (which files, at what level, etc) to be sure of it.

If someone can reply here with css suitable for highlighting online/active items in a table and the file/s to add it to, or add the css to the themes file/s so that all I have to do is modify the PR to add the newly added class to any active leases, I can do the rest happily.

I'm assuming it would ideally be an extra css class in the theme css file/s as described above, not just in the leases page, since the same improvement could conceptually apply to other tables with active/inactive members, and should be re-themable by user themes.

Owner

rbgarga commented May 27, 2015

pfSense is moving to bootstrap, as you can see in https://github.com/SjonHortensius/pfsense. I'm not sure if it's worth it to make this change to all themes at this point.

rbgarga closed this Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment