Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks read #18

Closed
lrweck opened this issue Oct 4, 2019 · 5 comments
Labels
bug

Comments

@lrweck
Copy link

@lrweck lrweck commented Oct 4, 2019

I've found a problem with block counting:

image

Full explain: https://pastebin.com/D8tw2hj5

@hairybreeches

This comment has been minimized.

Copy link
Collaborator

@hairybreeches hairybreeches commented Oct 4, 2019

That doesn't look right. Sorry about that, I didn't think that would be possible. I'll have a dig into the causes on Monday and get back to you.

@hairybreeches

This comment has been minimized.

Copy link
Collaborator

@hairybreeches hairybreeches commented Oct 7, 2019

Hi Luis -

Just to update you with where we are on this, it looks like an issue where some blocks have been double counted in the query plan. I think this has happened because one of the nodes is an InitPlan node which is used both as itself and as an input into another node.

We are taking this very seriously and are working on a way to identify when/how these blocks are double counted in the query plans, but it might take us a couple of days to do this.

Thanks for tipping us off about this issue.

Dave

@hairybreeches hairybreeches referenced this issue Oct 7, 2019
@mchristofides mchristofides added the bug label Oct 7, 2019
@hairybreeches

This comment has been minimized.

Copy link
Collaborator

@hairybreeches hairybreeches commented Oct 15, 2019

Hi Luis -
We think we've got a fix for this issue, but unfortunately we believe that the postgres behaviour which causes it is version-dependent.

We're waiting on confirmation from the postgres mailing lists, and if we're right we'll add a way for people to tell us which version of postgres they're using, and then we'll be able to deploy the fix (when applicable).

Thanks for bearing with us on this issue.

Dave

@hairybreeches

This comment has been minimized.

Copy link
Collaborator

@hairybreeches hairybreeches commented Oct 21, 2019

Hi Luis -

We've deployed a fix for this issue, let us know if you see any more similar problems like this in the future.

Thanks again for your patience with this one - it turned out to be a toughie!

This fix was added in commit 218d1bd957bf2d1187f689a76c3cb3c266b51367, deployed at 14:22 21/10/2019

@lrweck

This comment has been minimized.

Copy link
Author

@lrweck lrweck commented Oct 21, 2019

Great! I'll keep testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.