Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSoC-2020- writing tests and clean code [Week 9] #112

Merged
merged 31 commits into from
Aug 2, 2020
Merged

GSoC-2020- writing tests and clean code [Week 9] #112

merged 31 commits into from
Aug 2, 2020

Conversation

prakashupes
Copy link
Member

No description provided.

@cvvergara
Copy link
Member

What is this file for?
.vscode/settings.json

cvvergara
cvvergara requested changes Jul 26, 2020
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
include/bipartite/pgr_bipartite_driver.hpp Show resolved Hide resolved
include/bipartite/pgr_bipartite_driver.hpp Outdated Show resolved Hide resolved
include/bipartite/pgr_bipartite_driver.hpp Outdated Show resolved Hide resolved
include/bipartite/pgr_bipartite_driver.hpp Outdated Show resolved Hide resolved
include/bipartite/pgr_bipartite_driver.hpp Outdated Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
@cvvergara
Copy link
Member

Issues with documentation:

https://github.com/pgRouting/GSoC-pgRouting/runs/912238094#step:7:224
https://github.com/pgRouting/GSoC-pgRouting/runs/912238094#step:7:1051

I dont understand why functions that you didnt do mark an error

@cvvergara
Copy link
Member

What happened? why Prim & Kruskal are messed up?
https://github.com/pgRouting/GSoC-pgRouting/pull/112/checks?check_run_id=912238179#step:7:225

cvvergara
cvvergara requested changes Jul 27, 2020
View reviewed changes
src/LTDTree/LTDTree.c Outdated
#include "drivers/LTDTree/LTDTree_driver.h"


PGDLLEXPORT Datum _pgr_lengauer_tarjan_dominator_tree (PG_FUNCTION_ARGS);
PG_FUNCTION_INFO_V1(_pgr_lengauer_tarjan_dominator_tree );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use camel case
So your function names should be:
_pgr_lengauertarjandominatortree in the C file
and _pgr_lengauerTarjanDominatorTree pgr_lengauerTarjanDominatorTree on the SQL files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix the name in all pgTap and docs where I used _pgr_lengauer_tarjan_dominator_tree.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ma'am

@prakashupes
Copy link
Member Author

What happened? why Prim & Kruskal are messed up?
https://github.com/pgRouting/GSoC-pgRouting/pull/112/checks?check_run_id=912238179#step:7:225

@cvvergara When I was developing two graphs common spanning tree then I put it inside the spanningTree folder. I edited the config file for spanningTree, maybe this is the reason for the errors but now I think it should not come. Because I moved all the files of spanningTree in the new branch.

@prakashupes prakashupes self-assigned this Jul 28, 2020
@prakashupes prakashupes added the Prakash Prakash Tiwari label Jul 28, 2020
@prakashupes prakashupes merged commit 1211a08 into pgRouting:gsoc-prakash Aug 2, 2020
@prakashupes prakashupes mentioned this pull request Aug 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvergara cvvergara cvvergara requested changes

Assignees

@prakashupes prakashupes

Labels
Prakash Prakash Tiwari
Projects
None yet
Milestone
GSoC 2020 third code period
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prakashupes @cvvergara