Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgRouting SQL coding standard for documents and examples #386

Open
sanak opened this issue Aug 2, 2015 · 6 comments
Open

pgRouting SQL coding standard for documents and examples #386

sanak opened this issue Aug 2, 2015 · 6 comments

Comments

@sanak
Copy link
Member

sanak commented Aug 2, 2015

PostGIS documents seem to be written by a certain rule (ST_XyzAbc and upper case SQL words .etc).
Should we follow the SQL coding standard except pgRouting function name (pgr_xyzAbc .etc) ?

@robe2
Copy link
Member

robe2 commented Aug 2, 2015

Probably not worth the effort. The reason PostGIS does that is to satisfy SQL/MM convention (and then we said might as well make all our functions that way even if they aren't SQL/MM to minimize on confusion). Since your functions aren't SQL/MM defined, you have no precedence for it. You just need to be consistent within your own functions/documentation which I think you are.

@sanak
Copy link
Member Author

sanak commented Aug 2, 2015

Okay. Thanks for confirmation.
(I forgot that SQL/MM is OGC standard...)

I found some inconsistencies in pgr_alphaShape and pgr_pointsAsPolygon documents.
So, I will keep this status as opened for another function documents for a while.

@woodbri
Copy link
Contributor

woodbri commented Aug 2, 2015

I think that we roughly were mimicing the postgis style because we are dependent on postgis so again just trying to be consistent. I don't think we are rigid about this or have even documented that we have a style. We might want to add a style guide statement to the development standards docs.

@sanak
Copy link
Member Author

sanak commented Aug 3, 2015

@woodbri Okay. Thanks for comment.

@cvvergara
Copy link
Member

Eventually we need a pgRouting standard on function names:

  • when to use acronyms
  • when to use words
  • how to indicate in the function name which "family" of functions it belongs to.

But I think also it will need a full review of how the family of functions are formed
A for versions 2.x all new families of functions are proposed, then before 3.0 this can be reviewed and make the standard.

@cvvergara cvvergara added this to the Release 3.0.0 milestone Aug 24, 2016
@cvvergara
Copy link
Member

#400 is related

@cvvergara cvvergara removed this from the Release 3.0.0 milestone Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants