chore(cloud): remove EDB BigAnimal cloud deployment feature#10018
Closed
asheshv wants to merge 1 commit into
Closed
chore(cloud): remove EDB BigAnimal cloud deployment feature#10018asheshv wants to merge 1 commit into
asheshv wants to merge 1 commit into
Conversation
BigAnimal was one of four cloud-deployment targets in the Cloud
Wizard alongside AWS RDS, Azure Database, and Google Cloud SQL.
Drop the integration entirely:
Backend
- Delete web/pgadmin/misc/cloud/biganimal/ (Flask blueprint,
nine endpoints: verification, projects, providers, regions,
db_types, db_versions, instance_types, volume_types,
volume_properties) and its unit tests.
- Delete web/pgacloud/providers/biganimal.py (CLI provider
backing the deploy_on_biganimal step).
- misc/cloud/__init__.py: drop the BigAnimal blueprint
registration, the deploy_on_biganimal dispatch branch, and
the clear_biganimal_session call from clear_cloud_session.
- misc/cloud/utils/__init__.py: drop the "EDB BigAnimal"
branch from CloudProcessDesc.
Frontend
- Delete biganimal.js / biganimal_schema.ui.js and the
biganimal.svg provider logo.
- cloud_constants.js: drop BIGANIMAL from CLOUD_PROVIDERS
and CLOUD_PROVIDERS_LABELS.
- cloud_components.jsx: drop getBigAnimalSummary import and
the corresponding branch in FinalSummary.
- ExternalIcon.jsx: drop the BigAnimal icon import and
exported component.
- CloudWizard.jsx: drop the BigAnimal step content
(cluster-type / instance / database / review branches),
the verification banner and authenticateBigAnimal flow, and
the unused PrimaryButton / isEmptyString imports. The
BigAnimal-only "Cluster Type" wizard step is removed
entirely; remaining steps renumber from 0-5 to 0-4, and the
AWS/Azure/Google credentials-step "skip the empty cluster
step" logic in onBeforeNext/onBeforeBack is dropped along
with it.
Docs
- Remove docs/en_US/cloud_edb_biganimal.rst and its six PNG
screenshots; drop the entry from cloud_deployment.rst's
toctree and provider list.
Comments
- utils/session.py and utils/tests/test_session_file_format.py
docstrings: drop BigAnimal from the cloud-credentials list.
Side-effect worth noting
- The Azure cluster-name availability check in onBeforeNext at
activeStep == 2 was dead code in the original wizard flow:
AWS/Azure/Google's step-1 resolve(true) skipped past the
BigAnimal-only "Cluster Type" step, so step 2's beforeNext
handler never fired. After renumbering, step 2 is now the
Azure Instance Specification step, which is precisely when
you'd want to verify the cluster name before advancing to
Database Details. The check is now actually exercised —
intentional and an improvement, not a regression.
Historical release notes and translation .po/.pot files are
intentionally left untouched — release notes are an archive of
what shipped at each version, and translations regenerate from
source on the next i18n pass.
Verified:
- pycodestyle --config=.pycodestyle clean on changed Python.
- yarn run eslint clean on changed JS/JSX.
- python regression/runtests.py --pkg misc.cloud: 19/19 pass.
- python regression/runtests.py --pkg utils.tests
.test_session_file_format: 18/18 pass.
- yarn run test:js-once: 824/824 pass.
WalkthroughThis pull request removes EDB BigAnimal cloud provider support from pgAdmin4, eliminating documentation pages, backend Flask blueprint and provider implementations, frontend wizard flow and UI components, and related utility references across documentation, Python backend, and JavaScript frontend code. ChangesBigAnimal Cloud Provider Removal
🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/pgadmin/misc/cloud/static/js/CloudWizard.jsx`:
- Around line 229-243: The code is inspecting res.data.success but
checkClusternameAvailbility already resolves res.data, so change the check to
use res.success (e.g., if (res && res.success == 0)). Also avoid passing the
whole Error object into gettext/setErrMsg; use the error's readable text
(error.message or error.toString()) and pass that to setErrMsg and to the reject
(e.g., setErrMsg([MESSAGE_TYPE.ERROR, gettext(error.message)]) and reject(new
Error(error.message))). Update references in the CLOUD_PROVIDERS.AZURE /
activeStep branch where setErrMsg, checkClusternameAvailbility, and reject are
used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c959869f-ffac-479b-b17e-e84166e94bbb
⛔ Files ignored due to path filters (7)
docs/en_US/cloud_biganimal_cluster.pngis excluded by!**/*.pngdocs/en_US/images/cloud_biganimal_cluster.pngis excluded by!**/*.pngdocs/en_US/images/cloud_biganimal_credentials.pngis excluded by!**/*.pngdocs/en_US/images/cloud_biganimal_database.pngis excluded by!**/*.pngdocs/en_US/images/cloud_biganimal_instance.pngis excluded by!**/*.pngdocs/en_US/images/cloud_biganimal_review.pngis excluded by!**/*.pngweb/pgadmin/static/img/biganimal.svgis excluded by!**/*.svg
📒 Files selected for processing (16)
docs/en_US/cloud_deployment.rstdocs/en_US/cloud_edb_biganimal.rstweb/pgacloud/providers/biganimal.pyweb/pgadmin/misc/cloud/__init__.pyweb/pgadmin/misc/cloud/biganimal/__init__.pyweb/pgadmin/misc/cloud/biganimal/tests/__init__.pyweb/pgadmin/misc/cloud/biganimal/tests/test_biganimal_session_state.pyweb/pgadmin/misc/cloud/static/js/CloudWizard.jsxweb/pgadmin/misc/cloud/static/js/biganimal.jsweb/pgadmin/misc/cloud/static/js/biganimal_schema.ui.jsweb/pgadmin/misc/cloud/static/js/cloud_components.jsxweb/pgadmin/misc/cloud/static/js/cloud_constants.jsweb/pgadmin/misc/cloud/utils/__init__.pyweb/pgadmin/static/js/components/ExternalIcon.jsxweb/pgadmin/utils/session.pyweb/pgadmin/utils/tests/test_session_file_format.py
💤 Files with no reviewable changes (11)
- docs/en_US/cloud_edb_biganimal.rst
- web/pgacloud/providers/biganimal.py
- web/pgadmin/misc/cloud/biganimal/tests/init.py
- web/pgadmin/misc/cloud/biganimal/tests/test_biganimal_session_state.py
- web/pgadmin/misc/cloud/static/js/cloud_constants.js
- web/pgadmin/misc/cloud/utils/init.py
- web/pgadmin/misc/cloud/static/js/biganimal_schema.ui.js
- web/pgadmin/misc/cloud/static/js/biganimal.js
- web/pgadmin/misc/cloud/biganimal/init.py
- web/pgadmin/misc/cloud/init.py
- web/pgadmin/static/js/components/ExternalIcon.jsx
Comment on lines
+229
to
243
| } else if (cloudProvider == CLOUD_PROVIDERS.AZURE | ||
| && activeStep == 2) { | ||
| setErrMsg([MESSAGE_TYPE.INFO, gettext('Checking cluster name availability...')]); | ||
| checkClusternameAvailbility(azureInstanceData.name) | ||
| .then((res)=>{ | ||
| if (res.data && res.data.success == 0 ) { | ||
| setErrMsg([MESSAGE_TYPE.ERROR, gettext('Specified cluster name is already used.')]); | ||
| }else{ | ||
| setErrMsg(['', '']); | ||
| } | ||
| resolve(); | ||
| }) | ||
| .catch((error) => { | ||
| }).catch((error)=>{ | ||
| setErrMsg([MESSAGE_TYPE.ERROR, gettext(error)]); | ||
| reject(new Error(gettext(error))); | ||
| }); |
There was a problem hiding this comment.
Use the resolved Azure payload shape and preserve readable error text
Line 234 checks res.data.success, but this helper resolves res.data already, so this check is misaligned. Also, Line 241/242 wraps an Error object with gettext(error), which can surface as [object Object] instead of the actual message.
Suggested fix
} else if (cloudProvider == CLOUD_PROVIDERS.AZURE
&& activeStep == 2) {
setErrMsg([MESSAGE_TYPE.INFO, gettext('Checking cluster name availability...')]);
checkClusternameAvailbility(azureInstanceData.name)
.then((res)=>{
- if (res.data && res.data.success == 0 ) {
- setErrMsg([MESSAGE_TYPE.ERROR, gettext('Specified cluster name is already used.')]);
- }else{
- setErrMsg(['', '']);
- }
- resolve();
+ if (!res?.success) {
+ const msg = gettext('Specified cluster name is already used.');
+ setErrMsg([MESSAGE_TYPE.ERROR, msg]);
+ reject(new Error(msg));
+ return;
+ }
+ setErrMsg(['', '']);
+ resolve();
}).catch((error)=>{
- setErrMsg([MESSAGE_TYPE.ERROR, gettext(error)]);
- reject(new Error(gettext(error)));
+ const msg = error?.message || gettext('Error while checking server name availability with Microsoft Azure.');
+ setErrMsg([MESSAGE_TYPE.ERROR, msg]);
+ reject(new Error(msg));
});
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/pgadmin/misc/cloud/static/js/CloudWizard.jsx` around lines 229 - 243, The
code is inspecting res.data.success but checkClusternameAvailbility already
resolves res.data, so change the check to use res.success (e.g., if (res &&
res.success == 0)). Also avoid passing the whole Error object into
gettext/setErrMsg; use the error's readable text (error.message or
error.toString()) and pass that to setErrMsg and to the reject (e.g.,
setErrMsg([MESSAGE_TYPE.ERROR, gettext(error.message)]) and reject(new
Error(error.message))). Update references in the CLOUD_PROVIDERS.AZURE /
activeStep branch where setErrMsg, checkClusternameAvailbility, and reject are
used.
dpage
pushed a commit
that referenced
this pull request
Jun 9, 2026
Removes the EDB BigAnimal cloud-deployment integration from the Cloud Wizard. AWS RDS, Azure Database, and Google Cloud SQL remain as the supported deployment targets. Covers the backend blueprint and pgacloud provider, the frontend wizard steps/components/constants/icons, the documentation page and screenshots, and stray BigAnimal references in docstrings. The BigAnimal-only "Cluster Type" wizard step is removed and the remaining steps renumber from 0-5 to 0-4. As a side effect, the Azure cluster-name availability check (previously dead code at activeStep == 2, skipped past by the now-removed step) is now exercised. Two latent bugs in that check are fixed at the same time: it inspected res.data.success although checkClusternameAvailbility already resolves res.data, so a name collision was never reported; and it passed an Error object to gettext(), which cannot render it. It now uses res.success and surfaces error.message with a readable fallback. A 9.16 Housekeeping release-note entry is added documenting the removal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Merged to Two review fixes were folded into the merge commit:
Thanks @asheshv! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the EDB BigAnimal cloud-deployment integration from the Cloud Wizard. AWS RDS, Azure Database, and Google Cloud SQL remain as the supported deployment targets.
What's gone
Backend
web/pgadmin/misc/cloud/biganimal/— Flask blueprint, nine endpoints (verification, projects, providers, regions, db_types, db_versions, instance_types, volume_types, volume_properties), and its unit tests.web/pgacloud/providers/biganimal.py— the pgacloud CLI provider that backed the actual deployment step.misc/cloud/__init__.py— BigAnimal blueprint registration,deploy_on_biganimaldispatch branch,clear_biganimal_sessioncall.misc/cloud/utils/__init__.py— the"EDB BigAnimal"branch fromCloudProcessDesc.Frontend
biganimal.js,biganimal_schema.ui.js, andbiganimal.svg.cloud_constants.js—BIGANIMALremoved fromCLOUD_PROVIDERSandCLOUD_PROVIDERS_LABELS.cloud_components.jsx—getBigAnimalSummaryimport and the corresponding branch inFinalSummary(theclusterTypeDatapropType too).ExternalIcon.jsx—BigAnimalIconimport and exported component.CloudWizard.jsx— all BigAnimal step content (cluster-type / instance / database / review), the verification banner, theauthenticateBigAnimalflow, and the now-unusedPrimaryButton/isEmptyStringimports.Wizard restructuring — The BigAnimal-only "Cluster Type" wizard step is removed entirely. Remaining steps renumber from 0–5 to 0–4, and the AWS/Azure/Google credentials-step "skip the empty cluster step" logic in
onBeforeNext/onBeforeBackis dropped along with it. Net effect for AWS/Azure/Google users: one less click-through-an-empty-step.Docs
docs/en_US/cloud_edb_biganimal.rstand six PNG screenshots removed.docs/en_US/cloud_deployment.rst— entry dropped from the toctree and provider description.Comment cleanup
utils/session.pyandutils/tests/test_session_file_format.pydocstrings — BigAnimal dropped from the cloud-credentials enumeration.What's intentionally untouched
release_notes_*.rst) — these are an archive of what shipped at each version. Editing them rewrites history..po/.potfiles — translations regenerate from source on the next i18n pass; touching them by hand creates churn.docs/proposals/2026-04-30-eliminate-rce-and-symlink-escape.md— a dated design proposal that lists BigAnimal as one of the cloud modules it analyzed. Same archival reasoning as release notes.Side-effect worth flagging
The Azure cluster-name availability check in
onBeforeNextatactiveStep == 2was dead code in the original wizard flow: AWS/Azure/Google's step-1resolve(true)skipped past the BigAnimal-only "Cluster Type" step, so step 2'sbeforeNexthandler never fired. After renumbering, step 2 is now the Azure Instance Specification step, which is precisely when you'd want to verify the cluster name before advancing to Database Details. The check is now actually exercised — intentional and an improvement, not a regression. Reviewers may want to double-check it works as expected against a real Azure backend.Test plan
pycodestyle --config=.pycodestyleclean on changed Python.yarn run eslint -c .eslintrc.jsclean on changed JS/JSX.python regression/runtests.py --pkg misc.cloud— 19/19 pass.python regression/runtests.py --pkg utils.tests.test_session_file_format— 18/18 pass.yarn run test:js-once— 824/824 pass.Summary by CodeRabbit
Documentation
Chores