Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-core solution #1

Closed
mikhailov opened this issue Mar 30, 2013 · 3 comments
Closed

in-core solution #1

mikhailov opened this issue Mar 30, 2013 · 3 comments

Comments

@mikhailov
Copy link

nginx-upload-module is widely known solution for reliable big files upload with resume option and it's really great to see it still supported even by new project name.

But still don't understand why not to just use in-core client_body_in_file_only functionality? It has a lack of documentation and nobody use it, but we tried and have some success on it. I can share my experience and configuration here if it necessary

@mikhailov
Copy link
Author

muti-part or binary-data difference is 4 extra lines only!

-----------------------------7dc1f42e3005a8
Content-Disposition: form-data; name="qqfile";filename="[filename]"
Content-Type: application/octet-stream

[bytes from data stream]
-----------------------------7dc1f42e3005a8--

@pgaertig
Copy link
Owner

Regarding client_body_in_file_only on; I explained it in https://github.com/vkholodkov/nginx-upload-module/issues/41#issuecomment-15683609 . Multi-part is not hard in protocol but it is harder when you want to resume them. Multi-part is low priority because I want to have bullet proof resumable uploads first.

@pgaertig
Copy link
Owner

@mikahailov thanks for your input. The method you mentioned works well in some scenarios. However I also needed chunked upload and on the fly SHA1 calculation. These should be without post-upload lag which joining chunk parts and separate calculation often causes.
Multi-part body request support is on my TODO list, they won't rather support resumability. That will be old-plain-form fallback only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants