Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icon for NickelMenu main menu on 4.23.15505 #84

Closed
pgaskin opened this issue Aug 12, 2020 · 5 comments · Fixed by #98
Closed

Custom icon for NickelMenu main menu on 4.23.15505 #84

pgaskin opened this issue Aug 12, 2020 · 5 comments · Fixed by #98

Comments

@pgaskin
Copy link
Owner

pgaskin commented Aug 12, 2020

See #78.

@NiLuJe
Copy link
Collaborator

NiLuJe commented Aug 27, 2020

Random thought: instead of/in the meantime, couldn't we simply re-purpose an existing one? (I was thinking of the Erlenmeyer of the "Beta" settings, or any of the existing gear/tool-like ones).

@pgaskin
Copy link
Owner Author

pgaskin commented Aug 27, 2020

instead of/in the meantime, couldn't we simply re-purpose an existing one

I was actually just thinking something along the same line. I'm considering making an experimental option for now to change the path used for the QPixmap, as that would allow loading it from an arbitrary resource or a file. That allows us to sidestep the decisions for this change for now.

The only thing I'm concerned about is I don't want experimental options to become widely-used and having people complain about breakage/removal/changes later. That's a discussion for #87, though.

@pgaskin pgaskin added this to the v0.5.0 milestone Nov 15, 2020
@pgaskin
Copy link
Owner Author

pgaskin commented Dec 2, 2020

I've decided to go with an experimental option to change the QPixmap path for now. I'll need to test what happens if it doesn't exist or is invalid, though, to make sure it won't cause any problems.

@acestronautical
Copy link

I tried setting:

experimental:menu_main_15505_icon_active:/images/reading/beta_features_hit.png
experimental:menu_main_15505_icon:/images/reading/beta_features.png

but it doesn't seem to be working. Is this supposed to work with the native paths on kobo?
(I have libra 2)

@pgaskin
Copy link
Owner Author

pgaskin commented Oct 4, 2022

Try adding another colon before the path and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants