Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uponline restart (-R) broken #113
Comments
This comment has been minimized.
This comment has been minimized.
Please test current master, does it work now? Seems the pidfile race was always there only now the cleanup slowed down shutdown it was exposed. But also the cleanup touches sockets, so it must be skipped for takeover. |
This comment has been minimized.
This comment has been minimized.
Hi Marko, master fixes the problem, thanks! I had some trouble extracting the diff to the last release from git because "git diff --submodule" isn't helpful at all there, so I had to manually extract it. Could you make a new release for this fix? TIA. |
This comment has been minimized.
This comment has been minimized.
Will do. Thank you for the report. |
markokr
closed this
Feb 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ChristophBerg commentedFeb 24, 2016
Hi,
with 1.7.1 the -R online restart feature seems to be broken:
pgbouncer.log:
... and the process is gone.
I've tried the two commits past 1.7.1 relevant to PID file handling (07df4a5 and 106dc7b (which is missing an "int err", btw)), but they didn't fix the problem.
On IRC I got the report that this is a regression in 1.7.1, i.e. 1.7 worked fine, but I haven't verified this.