Repository navigation
Unbreak windows CI - #1009
Merged
Merged
Unbreak windows CI#1009
Conversation
JelteF
force-pushed
the
fix-windows-ci-attempt-2
branch
2 times, most recently
from
January 23, 2024 15:22
0e872db to
94fff2a
Compare
Windows CI was broken due to two things: 1. Static linking to OpenSSL causes `./configure` to fail 2. The `test_hba_leak` test was failing This fixes these issues, but it OpenSSL tests are now broken on Windows. Fixing that is left for a future PR; but for now this fixes CI so we don't introduce other breakages in the mean time (like number 2).
JelteF
force-pushed
the
fix-windows-ci-attempt-2
branch
from
January 23, 2024 15:27
94fff2a to
fdf5d3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI was broken due to two things:
./configureto failtest_hba_leaktest was failingThis fixes these issues, but SSL tests are now broken on Windows.
Fixing that is left for a future PR by disabling SSL tests for for now.
This way we at least don't introduce other breakages in the mean
time (like number 2).