Support --config=value format in options startup parameter #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-c config=value` pattern has been supported in PgBouncer since PR pgbouncer#878. As described in pgbouncer#952 Postgres also allows to use the `--config=value`, which honestly seems more readable, but for some reason is mentioned almost nowhere in the Postgres documentation. Since pgbouncer#878 this always throws an error, and putting `options` in `ignore_startup_parameters` wouldn't get rid of this error. So this should actually be considered a regression for the same reason as pgbouncer#907 was considered a regression (although a much less impactful one given we've only received two reports of this causing issues). Fixes pgbouncer#952
JelteF
changed the title
emelsimsek
approved these changes
May 10, 2024
Contributor
emelsimsek
left a comment
emelsimsek
left a comment
There was a problem hiding this comment.
Testing this locally, and reviewing the change it looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-c config=valuepattern has been supported in PgBouncer sincePR #878. As described in #952 Postgres also allows to use the
--config=value, which honestly seems more readable, but for somereason is mentioned almost nowhere in the Postgres documentation.
Since #878 this always throws an error, and putting
optionsinignore_startup_parameterswouldn't get rid of this error. So thisshould actually be considered a regression for the same reason as #907
was considered a regression (although a much less impactful one given
we've only received two reports of this causing issues).
Fixes #952