Fix for #1098 [memory leaks]#1099
Merged
Merged
Conversation
This commit fixes a memory leaks in parse_database function. 1. Description of database can define 'host' and 'connect_query' twice. We should free previous strings 2. 'fail' section must release allocated strings for 'host' and 'connect_query' parameters
This commit fixes a memory leaks in parse_peer function. 1. Description of database can define 'host' twice. We should free the previous string 2. 'fail' section must release an allocated string of 'host' parameter
JelteF
reviewed
Aug 18, 2024
JelteF
reviewed
Aug 18, 2024
JelteF
requested changes
Aug 18, 2024
JelteF
left a comment
JelteF
left a comment
Member
There was a problem hiding this comment.
The setting to NULL in the happy path and then the later Assert(NULL) calls are a bit unnecessary. Other than that this looks good.
Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
It JelteF' suggestion.
JelteF
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes memory leaks in parse_database and parse_peer functions.
See #1098 for details.