Fix for #1100 [parse_ident_line (hba.c)]#1101
Merged
emelsimsek merged 5 commits intoAug 12, 2024
Merged
Conversation
1. This function did not check strdup results 2. This function could return by error without cleanup 3. This function did not free map_name_copy in 'failed' section Additional DEBUG checks: 1. 'failed' section cannot get a not null value of ident_map. I suggest to remove "ident_map_free(ident_map);" from there.
emelsimsek
requested changes
Jul 4, 2024
Contributor
|
@dmitry-lipetsk thank you for catching the strdup issues here. |
emelsimsek
requested changes
Jul 4, 2024
I offer to delete ident_map_free(ident_map), too. After successful allocation of ident_map, it connected to ident->maps. If we theoretically free ident_map in 'failed' section, ident->maps will point to an invalid memory block.
emelsimsek
reviewed
Jul 4, 2024
emelsimsek
requested changes
Jul 4, 2024
Let's reset map_name_copy pointer after deallocating (free) and after assigning to ident_map->map_name. A smart compiler can decide to skip these unnecessary operations.
emelsimsek
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes different problems in function parse_ident_line (hba.c).
Additional DEBUG checks: