Handle auth_query correctly for replication connections

[JelteF]

The way we send an auth_query is a bit strange. We temporarily set the
pool of the client to the pool for the auth_user, and then continue
connection startup like normal. This broke for replication connections
because we would send the replication parameter for that connection too.
This fixes that by only doing our special connection setup logic for
replication connections if we're not currently trying to send an
auth_query.

Fixes #1164

[dbarrosop]

Hi, how is it going? just wanted to check if there was any progress here as this is still not working as expected. Thanks!

[eulerto]

For some reason, the test_physical_rep_pg_basebackup is failing for me. There is no explicit errors in the log (Postgres and PgBouncer).

==================================================== short test summary info =====================================================
FAILED test/test_replication.py::test_physical_rep_pg_basebackup - Failed: Timeout >30.0s
=============================== 1 failed, 210 passed, 7 skipped, 13 warnings in 138.12s (0:02:18) ================================
make: *** [Makefile:162: check] Error 1

[JelteF]

For some reason, the test_physical_rep_pg_basebackup is failing for me. There is no explicit errors in the log (Postgres and PgBouncer).

Is this only with this PR, or also on master? I cannot reproduce it, and CI is running fine too. So I'm leaning towards merging this unless this is only happening on this PR for you.

Regarding debugging, did you uncomment the following line during the test? That should give much more info into what's happening.
https://github.com/pgbouncer/pgbouncer/blob/master/test/utils.py#L919

[benchub]

FWIW, this issue was blocking us (because it turns out HUP'ing pgBouncer also resets connections which were made with credentials found in auth_file, and resetting logical replication connections on a regular basis is not great), but applying this patch seems to work well in our testing.

With this patch, we can now successfully establish and maintain a logical replication session authenticated with auth_query, even while we HUP pgBouncer every few minutes.

[d3qtian]

Hi @JelteF
Thank you for addressing this issue and providing a fix! We are currently in urgent need of this functionality for our project. Could you kindly let us know when this fix will be released in the next version of pgbouncer? Your update will help us plan accordingly.

Thanks again for the great work and support!