Improve code quality - #1169
Merged
Merged
Conversation
Pointed out by Coverity.
event_add() returns an integer that is ignored by the current code. Use the return to provide information about an event_add() issue. Pointed out by Coverity.
The find_database() function might return NULL. However, this is not true for this code path because there is always a database called "pgbouncer". Rearrange the code to only call get_pool() if the db variable is not null. Pointed out by Coverity.
It only makes sense to test if a variable (ident) is NULL before using it. There is a similar code path in hba_load_rules(). Pointed out by Coverity.
JelteF
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These issues were pointed out by Coverity.