Merged
Conversation
Contributor
Author
|
Rebased this PR to include the kill_client functionality. Also converted the kill_client functionality to use the numeric id implemented in this PR instead of the client pointer. |
eulerto
requested changes
Oct 9, 2024
Member
|
@AndrewJackson2020 It seems in good shape. I'll give another look and merge it soon. |
Contributor
Author
Great to hear, thank you. |
eulerto
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a numeric identifier to the PgSocket struct which can be used as a unique identifier for clients. Currently the unique identifier that pgbouncer uses is the pointer address of the struct, this suffices as a point in time identifier but over time these addresses are reused because of the dynamics of slab allocation.
This PR could help address a potential issue with #1147.