Separate error handling for empty pidfile#1195
Merged
eulerto merged 3 commits intopgbouncer:masterfrom Oct 31, 2024
Merged
Conversation
eulerto
requested changes
Oct 31, 2024
Member
eulerto
left a comment
eulerto
left a comment
There was a problem hiding this comment.
This PR seems reasonable to me. However, I have some suggestion. Instead of having a different message for this case (empty file), use goto locked_pidfile. It reports exact situation. I also suggest that you change the goto message to include the pidfile name.
greg-rychlewski
force-pushed
the
pidfile
branch
from
c6c5a48 to
82341c8
Compare
Contributor
Author
|
Thank you :). Updated. |
eulerto
approved these changes
Oct 31, 2024
rajaryanece
pushed a commit
to rajaryanece/pgbouncer
that referenced
this pull request
Jan 16, 2025
If a pid file exists but was empty, the current error message was that PgBouncer could not read the file. It is bogus. Instead, provide another message saying the file exists. Closes pgbouncer#1174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1174