Handle null from add_global_user#1202
Merged
Merged
Conversation
It replaces find_global_user or add_global_user. Also, we check result of find_exist_or_add_new_global_user. See pgbouncer#1111.
It replaces calls of find_global_credentials+add_global_credentials. Also, we check a result of find_exist_or_add_new_global_credentials if it needs. See pgbouncer#1111. NOTE: add_global_credentials is not used now.
Comment was corrected. Thanks to JelteF. Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
Comment was corrected. Thanks to JelteF. Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
Comment was corrected. Thanks to JelteF. Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
create_new_global_user inits user->pool_list, not user->credentials.pool_list
Thanks to JelteF for this recommendation.
greg-rychlewski
force-pushed
the
fix1111-v1
branch
from
2da0b81 to
65b4241
Compare
greg-rychlewski
force-pushed
the
fix1111-v1
branch
from
65b4241 to
6f0b229
Compare
greg-rychlewski
changed the title
JelteF
approved these changes
Dec 2, 2024
rajaryanece
pushed a commit
to rajaryanece/pgbouncer
that referenced
this pull request
Jan 16, 2025
This fixes a bunch of possible null dereferences in case of malloc returning NULL, i.e. when we're running out of memory. It's heavily based on pgbouncer#1112 Closes pgbouncer#1111 Closes pgbouncer#1112 Co-authored-by: Dmitry Kovalenko <dmitry.lipetsk@gmail.com> Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1111
Closes #1112
I had an interest in closing this one out. The original author has mentioned they don't have the time anymore.
I kept all the commits from the old PR and just added one last commit to address the last comment here: #1112 (comment)
I also renamed create_new_global_user to add_new_global_user to be more in line with the naming of find_or_add_new_global_user.
@JelteF Hope it's alright with you. If you had other plans for the old PR please let me know and I can close this one.