Change db param to reserve_pool_size - #1232
Merged
Merged
Conversation
JelteF
reviewed
Dec 23, 2024
JelteF
reviewed
Dec 23, 2024
Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
JelteF
approved these changes
Dec 24, 2024
rajaryanece
pushed a commit
to rajaryanece/pgbouncer
that referenced
this pull request
Jan 16, 2025
Based on discussion here: pgbouncer#1228 Updating the database parameter name from `reserve_pool` to `reserve_pool_size` to be consistent with everything else.
greeddj
added a commit
to greeddj/pgbouncer_exporter
that referenced
this pull request
May 22, 2026
PgBouncer 1.24.0 renamed the `reserve_pool` column in `SHOW DATABASES` to `reserve_pool_size` (pgbouncer/pgbouncer#1232). The exporter only mapped the old column name, so the `pgbouncer_databases_reserve_pool` metric silently stopped being emitted on PgBouncer 1.24+. Add a mapping for `reserve_pool_size` next to the existing `reserve_pool` entry, both pointing at the same metric name. The exporter iterates over the actual columns returned by pgbouncer, and the two names are mutually exclusive across versions, so the metric continues to be emitted exactly once per database row regardless of pgbouncer version. Add tests covering both column names. Refs: prometheus-community#220 Signed-off-by: Dmitrij Shishkin <greeddj@gmail.com>
SuperQ
pushed a commit
to prometheus-community/pgbouncer_exporter
that referenced
this pull request
Jun 26, 2026
PgBouncer 1.24.0 renamed the `reserve_pool` column in `SHOW DATABASES` to `reserve_pool_size` (pgbouncer/pgbouncer#1232). The exporter only mapped the old column name, so the `pgbouncer_databases_reserve_pool` metric silently stopped being emitted on PgBouncer 1.24+. Add a mapping for `reserve_pool_size` next to the existing `reserve_pool` entry, both pointing at the same metric name. The exporter iterates over the actual columns returned by pgbouncer, and the two names are mutually exclusive across versions, so the metric continues to be emitted exactly once per database row regardless of pgbouncer version. Add tests covering both column names. Refs: #220 Signed-off-by: Dmitrij Shishkin <greeddj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion here: #1228
Updating the database parameter name from
reserve_pooltoreserve_pool_sizeto be consistent with everything else.Do you prefer to advertise the deprecation through the release notes only or also make a note in the parameter's documentation?