Ignore cancel request during setting server variables#298
Merged
JelteF merged 5 commits intopgbouncer:masterfrom Dec 8, 2024
Merged
Ignore cancel request during setting server variables#298JelteF merged 5 commits intopgbouncer:masterfrom
JelteF merged 5 commits intopgbouncer:masterfrom
Conversation
pgbouncer called 'sbuf_pause' to block the request from client during setting variables in 'find_server'. However, cancel request to Postgresql backend is sent through a new connection from psql client. In this case, the 'SET' SQL will be cancelled and an error message 'invalid server parameter' is returned to client, which is confusing from the psql client side.
|
Hi, |
Member
|
This seems like a real bug, and the fix was very small and looked sensible. So I resolved the merge conflicts. |
JelteF
approved these changes
Dec 2, 2024
rajaryanece
pushed a commit
to rajaryanece/pgbouncer
that referenced
this pull request
Jan 16, 2025
pgbouncer called 'sbuf_pause' to block the request from client during setting variables in 'find_server'. However, cancel request to Postgresql backend is sent through a new connection from psql client. In this case, the 'SET' SQL will be cancelled and an error message 'invalid server parameter' is returned to client, which is confusing from the psql client side. Co-authored-by: Peifeng Qiu <pqiu@pivotal.io> Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgbouncer called 'sbuf_pause' to block the request from client during setting variables in 'find_server'. However, cancel request to Postgresql backend is sent through a new connection from psql client. In this case, the 'SET' SQL will be cancelled and an error message 'invalid server parameter' is returned to client, which is confusing from the psql client side.