Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create an auth_user if auth_query returned no result [fixes #290] #340

Closed
wants to merge 1 commit into from

Conversation

mpalmer
Copy link

@mpalmer mpalmer commented Nov 8, 2018

Checks that the username field of the DataRow packet actually contains
some data before blindly copying its contents around. Prevents ugly
log messages and, potentially, other more serious problems.

…ouncer#290]

Checks that the username field of the DataRow packet actually contains
some data before blindly copying its contents around.  Prevents ugly
log messages and, potentially, other more serious problems.
@a1exsh
Copy link

a1exsh commented Jun 19, 2019

Fixes #290

@petere petere added the bug something is broken label Sep 14, 2019
@SamSaffron
Copy link

@petere anything we can do to help get this merged, would you like a test?

@petere petere closed this in d149b26 Feb 18, 2020
@petere
Copy link
Member

petere commented Feb 18, 2020

Thanks for the contribution. I made it an error instead. Also, the test had to be moved up before the second "bad packet" check, because the bogus negative length was already used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants