Don't create an auth_user if auth_query returned no result [fixes #290] #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouncer#290] Checks that the username field of the DataRow packet actually contains some data before blindly copying its contents around. Prevents ugly log messages and, potentially, other more serious problems.
|
Fixes #290 |
|
@petere anything we can do to help get this merged, would you like a test? |
Member
|
Thanks for the contribution. I made it an error instead. Also, the test had to be moved up before the second "bad packet" check, because the bogus negative length was already used there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that the username field of the DataRow packet actually contains
some data before blindly copying its contents around. Prevents ugly
log messages and, potentially, other more serious problems.