Send FATAL when client is disconnected. #564
Closed
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dirvers do not recognize ERRORs when thay are followed by disconnect. If drivers recieves FATAL - it's prepared to unecpected EOF.
Member
|
I don't see any callers for this new function. Am I missing something? |
Author
|
Oops, sorry. I had forgotten to add a file. |
|
@x4m Thank you for the fix. We experienced the same issue and tried the patched version of pgbouncer but still have an issue with "unexpected EOF" error. Do we need also to apply some additional fixes on the library side like jackc/pgconn#64 ? |
Author
|
@damour this PR ought to be enough. Consider using Odyssey, BTW, I've already merged a similar patch there :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some drivers do not recognize ERRORs when they are followed by a disconnect.
If drivers receive FATAL - it's prepared for unexpected EOF.