Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send FATAL when client is disconnected. #564

Closed
wants to merge 2 commits into from

Conversation

x4m
Copy link

@x4m x4m commented Jan 31, 2021

Some drivers do not recognize ERRORs when they are followed by a disconnect.
If drivers receive FATAL - it's prepared for unexpected EOF.

Some dirvers do not recognize ERRORs when thay are followed by disconnect.
If drivers recieves FATAL - it's prepared to unecpected EOF.
@petere
Copy link
Member

petere commented Feb 10, 2021

I don't see any callers for this new function. Am I missing something?

@x4m
Copy link
Author

x4m commented Feb 10, 2021

Oops, sorry. I had forgotten to add a file.

@damour
Copy link

damour commented Mar 3, 2021

@x4m Thank you for the fix. We experienced the same issue and tried the patched version of pgbouncer but still have an issue with "unexpected EOF" error. Do we need also to apply some additional fixes on the library side like jackc/pgconn#64 ?

@x4m
Copy link
Author

x4m commented Mar 3, 2021

@damour this PR ought to be enough. Consider using Odyssey, BTW, I've already merged a similar patch there :)

@petere petere closed this in 87dd95e Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants