Fixed multiple sequential queries warning logging #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any news on when this might be merged/released? |
petere
added a commit
to petere/pgbouncer
that referenced
this pull request
Jul 9, 2021
Running multiple queries in a pipelined way would trigger the dreaded "FIXME: query end, but query_start == 0" log messages because when the first query finishes, we reset the query_start, and then the return of the second query gets upset. To fix that, only compute the time when all queries in flight have finished. solution by @vonzshik closes pgbouncer#39, closes pgbouncer#144, closes pgbouncer#215, closes pgbouncer#277, closes pgbouncer#376, closes pgbouncer#565
Member
|
Well, this certainly explains a lot. Especially how many people persistently see this and it's hard to reproduce for others, since it requires queries to be sent in this pipelined kind of way. I was now able to reproduce this with PostgreSQL 15's new libpq pipeline mode. I agree your solution is sensible. I have also taken this opportunity to restructure this code a bit and linked in all the related GitHub issues in #628. |
Author
petere
added a commit
that referenced
this pull request
Jul 13, 2021
Running multiple queries in a pipelined way would trigger the dreaded "FIXME: query end, but query_start == 0" log messages because when the first query finishes, we reset the query_start, and then the return of the second query gets upset. To fix that, only compute the time when all queries in flight have finished. solution by @vonzshik closes #39, closes #144, closes #215, closes #277, closes #376, closes #565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
The problem here is if multiple queries ("BEGIN TRANSACTION ...", "UPDATE ...") are sent together (that is, we're not waiting for a response from "BEGIN TRANSACTION ..." and immediately send another query to save a roundtrip), the query's
query_timeis set to 0 on the first query response, so there will be a warning for the second one.The proposed solution is to reset the
query_timeonly on the last RFQ. While it's not actually correct, the only other idea I have is to add a queue, which seems like a lot of overhead.