Fail sbuf_send_pending operation if dst socket is closed #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the dst socket is closed, sbuf_send_pending will fail but not mark the operation as failed. It will then retry repeatedly, consuming a lot of CPU until pgbouncer is restarted.
|
How do you get into that situation? Is that something we can cover with a test case? |
|
I'm not sure how it happens. It doesn't happen often. But when it happens it's really bad. pgbouncer starts using 100% of it's CPU core and starts flooding the logs with errors. The only way to stop it is by restarting it. Please merge this simple workaround for this issue. |
|
@petere we are looking forward to this fix |
|
Is this likely to make it into the next release? we started hitting this error in version 1.12 have then updated to 1.16 & 1.17 where we are still experiencing it... its very intermittent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dst socket is closed,
sbuf_send_pendingwill fail but not mark the operation as failed.It will then retry repeatedly, consuming a lot of CPU until pgbouncer is restarted.