Fail hard if a listen_addr could not be listened on #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails if listen_addr was specified, but none of the addresses could be listened on successfully. While not being able to listen on some of the addresses is often acceptable in practice, not being able to listen on any of them clearly indicates an error. This behaviour is the same as how Postgres its behaviour.
petere
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails if listen_addr was specified, but none of the addresses could
be listened on successfully. While not being able to listen on some of
the addresses is often acceptable in practice, not being able to listen
on any of them clearly indicates an error.
This behaviour is the same as how Postgres its behaviour.
Related to #830