Change default server_tls_sslmode to prefer - #866
Merged
Conversation
JelteF
force-pushed
the
change-default-server-tls-mode
branch
3 times, most recently
from
June 12, 2023 20:47
3d34467 to
712cb1c
Compare
libpq has been defaulting to prefer for a long time already. Obviously connecting over TLS is more secure, than without. The current approach of defaulting to `disable` actually breaks connecting if your server requires TLS, which many cloud providers are doing (by default at least). Fixes pgbouncer#843
JelteF
force-pushed
the
change-default-server-tls-mode
branch
from
July 4, 2023 11:53
712cb1c to
6533832
Compare
JelteF
added a commit
that referenced
this pull request
Jul 12, 2023
I missed the docs update in #866
JelteF
added a commit
to JelteF/pgbouncer
that referenced
this pull request
Feb 16, 2024
This reverts commit 370bc07.
eulerto
added a commit
to eulerto/pgbouncer
that referenced
this pull request
Aug 2, 2024
Issue pgbouncer#866 changed the default server_tls_sslmode to prefer but forgot to update the configuration file.
eulerto
added a commit
that referenced
this pull request
Aug 2, 2024
Issue #866 changed the default server_tls_sslmode to prefer but forgot to update the configuration file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpq has been defaulting to prefer for a long time already. Obviously
connecting over TLS is more secure, than without.
The current approach of defaulting to
disableactually breaksconnecting if your server requires TLS, which many cloud providers are
doing (by default at least).
Fixes #843