Don't kill all waiting clients on temporary FATAL errors during login #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server connection returns a FATAL error in the login phase we kill all the waiting clients and show this error to the user. The reason is that when this happens it's usually because of some configuration error (e.g. pg_hba.conf on Postgres not being configured correctly). But there are common cases where the error is temporary too, most importantly: "the database system is starting up" Postgres returns a specific error code for these types of errors. This PR starts checking for that error code, and won't disconnect the clients when it received a FATAL error from the server with that specific error code. The primary reason I spent time to fix this is because it was making our tests flaky: https://cirrus-ci.com/task/5607330616705024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server connection returns a FATAL error in the login phase we
kill all the waiting clients and show this error to the user. The reason
is that when this happens it's usually because of some configuration
error (e.g. pg_hba.conf on Postgres not being configured correctly).
But there are common cases where the error is temporary too, most
importantly: "the database system is starting up"
Postgres returns a specific error code for these types of errors. This
PR starts checking for that error code, and won't disconnect the clients
when it received a FATAL error from the server with that specific error
code.
The primary reason I spent time to fix this is because it was making
our tests flaky:
https://cirrus-ci.com/task/5607330616705024