Fallback to C locale on systems without C.UTF-8 #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/locale-name-fix
branch
from
71bf5f4 to
98a64c0
Compare
syvb
force-pushed
the
sv/locale-name-fix
branch
from
98a64c0 to
0630a25
Compare
Member
|
Hm. Please document this fallback logic in one of our READMEs somewhere? It's getting complicated enough that users should be aware of the system differences. |
Contributor
Author
|
I documented the locale behavior for the |
Member
workingjubilee
left a comment
workingjubilee
left a comment
There was a problem hiding this comment.
Thank you. Hopefully no one will have to care, but inevitably someone is going to want to, say, port software from CentOS 7 to Rocky Linux 8.
Just one other nit.
Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
workingjubilee
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7 doesn't support the
C.UTF-8locale, so cargo-pgx doesn't work on CentOS 7 since it tries to set a databases locale toC.UTF-8. Rocky Linux >= 8 does have theC.UTF-8locale and works fine.This PR makes pgx fallback to the
Clocale on systems without theC.UTF-8locale (according tolocale, and defaulting toCiflocalefails to run).