Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Dec 8, 2025

Add worker_functions table to reset_db and enhance HTTP request tests

This PR improves the database reset functionality by adding the worker_functions table to the list of tables cleared during reset operations.

It also enhances the test coverage for worker function HTTP requests by adding several new test cases that verify:

  1. The correct construction of HTTP request URLs using base URLs from Vault
  2. Proper inclusion of service role keys in Authorization headers when using Vault credentials
  3. Appropriate fallback behavior for local development environments
  4. Verification of the URL format pattern for function invocations

These changes ensure that worker functions are properly invoked with the correct credentials and endpoints in both production and local development environments.

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: c752278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

jumski commented Dec 8, 2025

@nx-cloud
Copy link

nx-cloud bot commented Dec 8, 2025

View your CI Pipeline Execution ↗ for commit c752278

Command Status Duration Result
nx test:types:health dsl ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-08 09:49:00 UTC

@jumski jumski force-pushed the 12-08-add_http_request_url_and_header_assertions_to_ensure_workers_tests branch from 0903a05 to 1dda0d3 Compare December 8, 2025 07:46
@jumski jumski force-pushed the 12-08-simplify_track_worker_function_by_removing_debounce_responsibility branch 2 times, most recently from a34d33c to 696273c Compare December 8, 2025 07:55
@jumski jumski force-pushed the 12-08-add_http_request_url_and_header_assertions_to_ensure_workers_tests branch from 1dda0d3 to 70bf4ce Compare December 8, 2025 07:55
Copy link
Contributor Author

jumski commented Dec 8, 2025

Merge activity

  • Dec 8, 8:07 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 8, 9:47 AM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 8, 9:48 AM UTC: @jumski merged this pull request with Graphite.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-521.pgflow.pages.dev

📝 Details:

  • Branch: 12-08-add_http_request_url_and_header_assertions_to_ensure_workers_tests
  • Commit: 4b4c248e0c81ee2c12943e6e7e6ee659547e8486
  • View Logs

_Last updated: _

@jumski jumski changed the base branch from 12-08-simplify_track_worker_function_by_removing_debounce_responsibility to graphite-base/521 December 8, 2025 09:45
@jumski jumski changed the base branch from graphite-base/521 to main December 8, 2025 09:46
@jumski jumski force-pushed the 12-08-add_http_request_url_and_header_assertions_to_ensure_workers_tests branch from 70bf4ce to c752278 Compare December 8, 2025 09:47
@jumski jumski merged commit d3d75d6 into main Dec 8, 2025
12 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🚀 Production Deployment: Website

Successfully deployed to production!

🔗 Production URL: https://pgflow.dev

📝 Details:

  • Commit: d3d75d6cba6afcf36df2f2b58415986103272205
  • View Logs

Deployed at: 2025-12-08T10:48:25+01:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants