Skip to content
Permalink
Browse files

Fix test suite order (#1593)

* test: Standardize on array of tests in @SuiteClasses

* test: Fix sort order for test suites

* docs: Add note about sorting tests to GitHub PR template
  • Loading branch information
sehrope authored and davecramer committed Oct 29, 2019
1 parent 7c59126 commit 003ea8352dab2b49b4734cdf7338befb4d9b9ed4
@@ -9,7 +9,7 @@

1. [ ] Does your submission pass tests?
2. [ ] Does mvn checkstyle:check pass ?
3. [ ] Have you added your new test classes to an existing test suite?
3. [ ] Have you added your new test classes to an existing test suite in alphabetical order?

### Changes to Existing Features:

@@ -12,7 +12,9 @@
* Executes all known tests for PostgreSQL extensions supported by JDBC driver
*/
@RunWith(Suite.class)
@Suite.SuiteClasses(HStoreTest.class)
@Suite.SuiteClasses({
HStoreTest.class,
})
public class ExtensionsTestSuite {
}

@@ -12,6 +12,8 @@
* Executes multi host tests (aka master/slave connectivity selection).
*/
@RunWith(Suite.class)
@Suite.SuiteClasses(MultiHostsConnectionTest.class)
@Suite.SuiteClasses({
MultiHostsConnectionTest.class,
})
public class MultiHostTestSuite {
}
@@ -15,13 +15,15 @@
* @author Aaron Mulder (ammulder@chariotsolutions.com)
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({SimpleDataSourceTest.class,
SimpleDataSourceWithUrlTest.class,
SimpleDataSourceWithSetURLTest.class,
@Suite.SuiteClasses({
BaseDataSourceFailoverUrlsTest.class,
CaseOptimiserDataSourceTest.class,
ConnectionPoolTest.class,
PoolingDataSourceTest.class,
CaseOptimiserDataSourceTest.class,
BaseDataSourceFailoverUrlsTest.class})
SimpleDataSourceTest.class,
SimpleDataSourceWithSetURLTest.class,
SimpleDataSourceWithUrlTest.class,
})
public class OptionalTestSuite {

}
@@ -15,10 +15,10 @@
GetObject310InfinityTests.class,
GetObject310Test.class,
Jdbc42CallableStatementTest.class,
LargeCountJdbc42Test.class,
PreparedStatementTest.class,
SetObject310Test.class,
SimpleJdbc42Test.class,
LargeCountJdbc42Test.class
})
public class Jdbc42TestSuite {

@@ -13,6 +13,8 @@
* Twitter: @codefinger
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({SocksProxyTest.class})
@Suite.SuiteClasses({
SocksProxyTest.class,
})
public class Jre8TestSuite {
}
@@ -10,7 +10,9 @@
import org.junit.runners.Suite.SuiteClasses;

@RunWith(Suite.class)
@SuiteClasses({PGDataSourceFactoryTest.class})
@SuiteClasses({
PGDataSourceFactoryTest.class,
})
public class OsgiTestSuite {

}
@@ -11,9 +11,9 @@
@RunWith(Suite.class)
@Suite.SuiteClasses({
CommonNameVerifierTest.class,
LazyKeyManagerTest.class,
LibPQFactoryHostNameTest.class,
SslTest.class,
LazyKeyManagerTest.class,
})
public class SslTestSuite {
}
@@ -9,6 +9,8 @@
import org.junit.runners.Suite;

@RunWith(Suite.class)
@Suite.SuiteClasses(XADataSourceTest.class)
@Suite.SuiteClasses({
XADataSourceTest.class,
})
public class XATestSuite {
}

0 comments on commit 003ea83

Please sign in to comment.
You can’t perform that action at this time.